Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: passing arguments with NPM #2563

Merged
merged 9 commits into from
Jun 20, 2024
Merged

fix: passing arguments with NPM #2563

merged 9 commits into from
Jun 20, 2024

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Jun 20, 2024
@petertonysmith94 petertonysmith94 added this to the 0.x mainnet milestone Jun 20, 2024
@petertonysmith94 petertonysmith94 self-assigned this Jun 20, 2024
danielbate
danielbate previously approved these changes Jun 20, 2024
View reviewed changes
arboleya
arboleya previously approved these changes Jun 20, 2024
View reviewed changes
nedsalk
nedsalk previously approved these changes Jun 20, 2024
View reviewed changes
@petertonysmith94 petertonysmith94 dismissed stale reviews from nedsalk and arboleya via 60daf89 June 20, 2024 14:48
@nedsalk nedsalk self-requested a review June 20, 2024 16:08
@arboleya arboleya requested review from danielbate and arboleya June 20, 2024 20:21
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
80.96%(-0.02%) 72.55%(+0.03%) 77.98%(+0%) 81.01%(-0.03%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/create-fuels/src/cli.ts 85.29%
(-2.94%)		 40%
(+2.5%)		 100%
(+0%)		 85.29%
(-2.94%)

@petertonysmith94 petertonysmith94 merged commit 95d351b into master Jun 20, 2024
20 checks passed
@petertonysmith94 petertonysmith94 deleted the ps/fix/passing-arguments-with-npm branch June 20, 2024 20:51
@fuel-service-user fuel-service-user mentioned this pull request Jun 20, 2024
Merged
nedsalk pushed a commit that referenced this pull request Jun 27, 2024
@petertonysmith94 @nedsalk
fix: passing arguments with NPM (#2563)
4807414 
* docs: added correct NPM option format

* chore: added npm to e2e test

* chore: changeset

* chore: made opts `no-install`

* chore: fix merge
@arboleya arboleya mentioned this pull request Jun 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@maschad maschad maschad approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@Torres-ssf Torres-ssf Awaiting requested review from Torres-ssf Torres-ssf is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
0.x mainnet
Development

Successfully merging this pull request may close these issues.

Passing arguments to create fuels via NPM
5 participants
@petertonysmith94 @arboleya @danielbate @maschad @nedsalk