Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix compiler warnings for libraries #124

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Conversation

sdankel
Copy link
Member

@sdankel sdankel commented Jul 25, 2024

Type of change

  • Improvement (refactoring, restructuring repository, cleaning tech debt, ...)

Changes

The following changes have been made:

  • fix dead code warnings
  • treat warnings as errors in CI for libraries

Related Issues

Closes #123

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.
  • I have updated the changelog to reflect the changes on this PR.

@sdankel sdankel requested a review from a team as a code owner July 25, 2024 17:29
@sdankel sdankel changed the title chore: fix compiler warnings chore: fix compiler warnings for libraries Jul 25, 2024
K1-R1
K1-R1 previously approved these changes Jul 25, 2024
@K1-R1 K1-R1 requested a review from a team July 25, 2024 20:38
@K1-R1
Copy link
Member

K1-R1 commented Jul 25, 2024

@sdankel Could you update the Changelog with the PR?

@K1-R1 K1-R1 requested a review from a team July 31, 2024 18:47
@DefiCake DefiCake self-requested a review August 1, 2024 18:11
@K1-R1 K1-R1 merged commit d736ca6 into master Aug 1, 2024
6 checks passed
@K1-R1 K1-R1 deleted the sophie/fix-warnings branch August 2, 2024 08:37
@bitzoic bitzoic mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run forc build --error-on-warnings in CI
4 participants