Code

Inserting Comments#2311

Code

Merged

kayagokalp merged 53 commits intomasterFuelLabs/sway:masterfrom kayagokalp/comment_insertingFuelLabs/sway:kayagokalp/comment_insertingCopy head branch name to clipboardJul 25, 2022

+1,730-54

Commits

Commits on Jul 5, 2022

• CommentedTokenTree::Comment case for span comment map implemented

  kayagokalp

  committed
  ee9abdb

Commits on Jul 6, 2022

• CommentSpan ordering fix and test added

  kayagokalp

  committed
  6b6681a

• clippy

  kayagokalp

  committed
  be4511c

• Handle in-block and next-to item cases for comment map generation

  kayagokalp

  committed
  9dc606a

• Comments in between items are added correctly.

  kayagokalp

  committed
  ddfb007

Commits on Jul 7, 2022

• remove premature comment addition

  kayagokalp

  committed
  fe5c851

• Merge branch 'master' into kayagokalp/2224

  kayagokalp

  authored
  9d48927

Commits on Jul 8, 2022

• removed FormatComment trait

  kayagokalp

  committed
  06b5968

• rename: get_comment_from_token_stream to collect_comments_from_token_stream, rename: construct_comment_map to comment_map_from_src

  kayagokalp

  committed
  d9cb274

Commits on Jul 11, 2022

• Merge branch 'master' into kayagokalp/2224

  kayagokalp

  authored
  d2b61ce

• Merge branch 'master' into kayagokalp/2224

  eureka-cpu

  authored
  2793a16

Commits on Jul 12, 2022

• comment ordering corrected

  kayagokalp

  committed
  bf9dcce

• Comment handling for inside Struct block implemented

  kayagokalp

  committed
  0f6d01e

• More context collected for whitespace preserving

  kayagokalp

  committed
  f8774ae

• test for comments added

  kayagokalp

  committed
  3bdc20b

Commits on Jul 13, 2022

• Added forgetten final value for punctuated

  kayagokalp

  committed
  86b4786

• removed test since it requires all item types to implement CommentVisitor

  kayagokalp

  committed
  d603a8f

• Until CommentVisitor implemented another check added for tests to pass

  kayagokalp

  committed
  934fb84

• Merge master

  kayagokalp

  committed
  e94e123

• CommentVisitor implemented for ItemEnum

  kayagokalp

  committed
  d518b67

• Add comment test

  kayagokalp

  committed
  018effd

• test extended to include enum

  kayagokalp

  committed
  6cfc34e

Commits on Jul 14, 2022

• CommentVisitor for ItemFn implemendted

  kayagokalp

  committed
  40bb416

• Do not search or insert comment between Punctuated's T and P.

  kayagokalp

  committed
  be4ed24

Commits on Jul 15, 2022

• Literal visitor implemented, pattern visitor updated

  kayagokalp

  committed
  120d601

• statement visitor implemented

  kayagokalp

  committed
  6c34f10

• Visitor for ItemFn implemented recursively, we can now insert comments anywhere possible in a ItemFn, a simple test added

  kayagokalp

  committed
  3f59e9f

• comment tests simplified

  kayagokalp

  committed
  68d4f02

• Merge master

  kayagokalp

  committed
  0fea7b9

• fix storage initializers for comment handler to parse formatted code correctly

  kayagokalp

  committed
  f2a3ab1

• clippy

  kayagokalp

  committed
  8a995f7

Commits on Jul 17, 2022

• Collecting more context for comments

  kayagokalp

  committed
  bdcfc4b

• Added in-between item comments

  kayagokalp

  committed
  47bffb3

Commits on Jul 18, 2022

• comments inside expr removed since formatter already includes them by default (it is not implemented yet)

  kayagokalp

  committed
  b4cc1cb

• ItemAbi CommentVisitor implemented

  kayagokalp

  committed
  fd6595e

• CommentVisitor for ItemConst implemented & removed unnecessary comments for other CommentVisitor implementations

  kayagokalp

  committed
  e163d1f

• CommentVisitor implemented for ItemStorage, Fixed a bug for Punctuated visiting, couple more comment refactoring

  kayagokalp

  committed
  e452fad

• CommentVisitor implemented for ItemTrait, Tuple visitor implemented for refactoring

  kayagokalp

  committed
  b63c955

Commits on Jul 19, 2022

• CommentVisitor for ItemImpl implemented

  kayagokalp

  committed
  92d815d

• CommentVisitor implemented for ItemUse

  kayagokalp

  committed
  356d3c2

• CommentVisitor for Module implemented, refactoring around add_comments

  kayagokalp

  committed
  dfcf38a

• Merge branch 'master' into kayagokalp/comment_inserting

  kayagokalp

  authored
  fdf8d6d

Commits on Jul 21, 2022

• CommentSpan -> ByteSpan renamed

  kayagokalp

  committed
  1c35627

• from_span() removed in favor of From<Span>

  kayagokalp

  committed
  13b3bec

• Prevent reparsing the unformatted_code as we already did it before formatting

  kayagokalp

  committed
  9ae7aa8

• refactor insert_after_span

  kayagokalp

  committed
  fd62f6d

• Split test_comments to seperate tests for better visibility, code refactoring around insertion

  kayagokalp

  committed
  4424ae8

• removed comments regarding comments inside PathType

  kayagokalp

  committed
  c8bc474

• Merge branch 'master' into kayagokalp/comment_inserting

  kayagokalp

  authored
  43e7650

Commits on Jul 22, 2022

• Merge branch 'master' into kayagokalp/comment_inserting

  kayagokalp

  committed
  9d6c924

• CommentVisitor -> LeafSpans and comment formatting fix

  kayagokalp

  committed
  5328b3d

• fmt fix

  kayagokalp

  committed
  c118303

Commits on Jul 25, 2022

• Merge branch 'master' into kayagokalp/comment_inserting

  mitchmindtree

  authored
  4bdb3b4