From cc63f68e4d803d3a10c053ab48259df500bd5e1a Mon Sep 17 00:00:00 2001 From: zakir <80246097+zakir-code@users.noreply.github.com> Date: Thu, 1 Aug 2024 17:41:54 +0800 Subject: [PATCH] refactor: remove unused interface for module (#612) --- x/arbitrum/module.go | 7 ------- x/avalanche/module.go | 7 ------- x/bsc/module.go | 7 ------- x/erc20/module.go | 8 -------- x/eth/module.go | 7 ------- x/ibc/applications/transfer/module.go | 7 ------- x/layer2/module.go | 7 ------- x/migrate/module.go | 7 ------- x/optimism/module.go | 7 ------- x/polygon/module.go | 7 ------- x/tron/module.go | 7 ------- 11 files changed, 78 deletions(-) diff --git a/x/arbitrum/module.go b/x/arbitrum/module.go index 7f7bb664..c9a75b6c 100644 --- a/x/arbitrum/module.go +++ b/x/arbitrum/module.go @@ -10,7 +10,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -54,9 +53,6 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo // RegisterLegacyAminoCodec implements app module basic func (AppModuleBasic) RegisterLegacyAminoCodec(_ *codec.LegacyAmino) {} -// RegisterRESTRoutes implements app module basic -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // RegisterGRPCGatewayRoutes registers the gRPC Gateway func (AppModuleBasic) RegisterGRPCGatewayRoutes(_ client.Context, _ *runtime.ServeMux) {} @@ -94,9 +90,6 @@ func NewAppModule(keeper crosschainkeeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers module services. func (am AppModule) RegisterServices(cfg module.Configurator) { migrator := crosschainkeeper.NewMigrator(am.keeper) diff --git a/x/avalanche/module.go b/x/avalanche/module.go index 79e72369..57a65915 100644 --- a/x/avalanche/module.go +++ b/x/avalanche/module.go @@ -10,7 +10,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -54,9 +53,6 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo // RegisterLegacyAminoCodec implements app module basic func (AppModuleBasic) RegisterLegacyAminoCodec(_ *codec.LegacyAmino) {} -// RegisterRESTRoutes implements app module basic -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // RegisterGRPCGatewayRoutes registers the gRPC Gateway func (AppModuleBasic) RegisterGRPCGatewayRoutes(_ client.Context, _ *runtime.ServeMux) {} @@ -94,9 +90,6 @@ func NewAppModule(keeper crosschainkeeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers module services. func (am AppModule) RegisterServices(cfg module.Configurator) { migrator := crosschainkeeper.NewMigrator(am.keeper) diff --git a/x/bsc/module.go b/x/bsc/module.go index bb13173f..dc3dc130 100644 --- a/x/bsc/module.go +++ b/x/bsc/module.go @@ -10,7 +10,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -54,9 +53,6 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo // RegisterLegacyAminoCodec implements app module basic func (AppModuleBasic) RegisterLegacyAminoCodec(_ *codec.LegacyAmino) {} -// RegisterRESTRoutes implements app module basic -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // RegisterGRPCGatewayRoutes registers the gRPC Gateway func (AppModuleBasic) RegisterGRPCGatewayRoutes(_ client.Context, _ *runtime.ServeMux) {} @@ -94,9 +90,6 @@ func NewAppModule(keeper crosschainkeeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers module services. func (am AppModule) RegisterServices(cfg module.Configurator) { migrator := crosschainkeeper.NewMigrator(am.keeper) diff --git a/x/erc20/module.go b/x/erc20/module.go index 2056ca23..ec3bd7e6 100644 --- a/x/erc20/module.go +++ b/x/erc20/module.go @@ -11,7 +11,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -51,10 +50,6 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo return state.Validate() } -// RegisterRESTRoutes performs a no-op as the erc20 module doesn't expose REST -// endpoints -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // RegisterGRPCGatewayRoutes registers the gRPC Gateway routes for the module. func (AppModuleBasic) RegisterGRPCGatewayRoutes(c client.Context, serveMux *runtime.ServeMux) { err := types.RegisterQueryHandlerClient(context.Background(), serveMux, types.NewQueryClient(c)) @@ -99,9 +94,6 @@ func NewAppModule(keeper keeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers a GRPC query service to respond to the // module-specific GRPC queries. func (am AppModule) RegisterServices(cfg module.Configurator) { diff --git a/x/eth/module.go b/x/eth/module.go index 5eebcdb7..dd63054a 100644 --- a/x/eth/module.go +++ b/x/eth/module.go @@ -10,7 +10,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -54,9 +53,6 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo // RegisterLegacyAminoCodec implements app module basic func (AppModuleBasic) RegisterLegacyAminoCodec(_ *codec.LegacyAmino) {} -// RegisterRESTRoutes implements app module basic -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // RegisterGRPCGatewayRoutes registers the gRPC Gateway func (AppModuleBasic) RegisterGRPCGatewayRoutes(_ client.Context, _ *runtime.ServeMux) {} @@ -94,9 +90,6 @@ func NewAppModule(keeper crosschainkeeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers module services. func (am AppModule) RegisterServices(cfg module.Configurator) { migrator := crosschainkeeper.NewMigrator(am.keeper) diff --git a/x/ibc/applications/transfer/module.go b/x/ibc/applications/transfer/module.go index 0636a135..d2aee78a 100644 --- a/x/ibc/applications/transfer/module.go +++ b/x/ibc/applications/transfer/module.go @@ -11,7 +11,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -53,9 +52,6 @@ func (AppModuleBasic) ValidateGenesis(_ codec.JSONCodec, _ client.TxEncodingConf return nil } -// RegisterRESTRoutes implements AppModuleBasic interface -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // RegisterGRPCGatewayRoutes registers the gRPC Gateway routes for the ibc-transfer module. func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *runtime.ServeMux) { err := types.RegisterQueryHandlerClient(context.Background(), mux, types.NewQueryClient(clientCtx)) @@ -90,9 +86,6 @@ func NewAppModule(k keeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers module services. func (am AppModule) RegisterServices(cfg module.Configurator) { types.RegisterMsgServer(cfg.MsgServer(), am.keeper) diff --git a/x/layer2/module.go b/x/layer2/module.go index 8b002c7c..ab88a545 100644 --- a/x/layer2/module.go +++ b/x/layer2/module.go @@ -10,7 +10,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -54,9 +53,6 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo // RegisterLegacyAminoCodec implements app module basic func (AppModuleBasic) RegisterLegacyAminoCodec(_ *codec.LegacyAmino) {} -// RegisterRESTRoutes implements app module basic -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // RegisterGRPCGatewayRoutes registers the gRPC Gateway func (AppModuleBasic) RegisterGRPCGatewayRoutes(_ client.Context, _ *runtime.ServeMux) {} @@ -94,9 +90,6 @@ func NewAppModule(keeper crosschainkeeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers module services. func (am AppModule) RegisterServices(cfg module.Configurator) { migrator := crosschainkeeper.NewMigrator(am.keeper) diff --git a/x/migrate/module.go b/x/migrate/module.go index 2fa28ff7..70806cce 100644 --- a/x/migrate/module.go +++ b/x/migrate/module.go @@ -11,7 +11,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -47,9 +46,6 @@ func (AppModuleBasic) ValidateGenesis(_ codec.JSONCodec, _ client.TxEncodingConf return nil } -// RegisterRESTRoutes implements app module basic -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // GetQueryCmd implements app module basic func (AppModuleBasic) GetQueryCmd() *cobra.Command { return cli.GetQueryCmd() @@ -94,9 +90,6 @@ func NewAppModule(keeper keeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers module services. func (am AppModule) RegisterServices(cfg module.Configurator) { types.RegisterMsgServer(cfg.MsgServer(), am.keeper) diff --git a/x/optimism/module.go b/x/optimism/module.go index 6d017f45..a36181c4 100644 --- a/x/optimism/module.go +++ b/x/optimism/module.go @@ -10,7 +10,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -54,9 +53,6 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo // RegisterLegacyAminoCodec implements app module basic func (AppModuleBasic) RegisterLegacyAminoCodec(_ *codec.LegacyAmino) {} -// RegisterRESTRoutes implements app module basic -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // RegisterGRPCGatewayRoutes registers the gRPC Gateway func (AppModuleBasic) RegisterGRPCGatewayRoutes(_ client.Context, _ *runtime.ServeMux) {} @@ -94,9 +90,6 @@ func NewAppModule(keeper crosschainkeeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers module services. func (am AppModule) RegisterServices(cfg module.Configurator) { migrator := crosschainkeeper.NewMigrator(am.keeper) diff --git a/x/polygon/module.go b/x/polygon/module.go index dc204fc6..104865fa 100644 --- a/x/polygon/module.go +++ b/x/polygon/module.go @@ -10,7 +10,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -50,9 +49,6 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo return state.ValidateBasic() } -// RegisterRESTRoutes implements app module basic -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // GetQueryCmd implements app module basic func (AppModuleBasic) GetQueryCmd() *cobra.Command { return crosschaincli.GetQueryCmd(types.ModuleName) @@ -90,9 +86,6 @@ func NewAppModule(keeper crosschainkeeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers module services. func (am AppModule) RegisterServices(cfg module.Configurator) { migrator := crosschainkeeper.NewMigrator(am.keeper) diff --git a/x/tron/module.go b/x/tron/module.go index e9acbbab..3ee318d0 100644 --- a/x/tron/module.go +++ b/x/tron/module.go @@ -10,7 +10,6 @@ import ( codectypes "github.com/cosmos/cosmos-sdk/codec/types" sdk "github.com/cosmos/cosmos-sdk/types" "github.com/cosmos/cosmos-sdk/types/module" - "github.com/gorilla/mux" "github.com/grpc-ecosystem/grpc-gateway/runtime" "github.com/spf13/cobra" @@ -51,9 +50,6 @@ func (AppModuleBasic) ValidateGenesis(cdc codec.JSONCodec, _ client.TxEncodingCo return state.ValidateBasic() } -// RegisterRESTRoutes implements app module basic -func (AppModuleBasic) RegisterRESTRoutes(_ client.Context, _ *mux.Router) {} - // GetQueryCmd implements app module basic func (AppModuleBasic) GetQueryCmd() *cobra.Command { return crosschaincli.GetQueryCmd(types.ModuleName) @@ -91,9 +87,6 @@ func NewAppModule(keeper keeper.Keeper) AppModule { // RegisterInvariants implements app module func (am AppModule) RegisterInvariants(_ sdk.InvariantRegistry) {} -// QuerierRoute implements app module -func (am AppModule) QuerierRoute() string { return "" } - // RegisterServices registers module services. func (am AppModule) RegisterServices(cfg module.Configurator) { migrator := crosschainkeeper.NewMigrator(am.keeper.Keeper)