fix: nil consensus params in BeginBlock during migration

[zakir-code]

Summary by CodeRabbit

• New Features

  • Enhanced error handling for consensus parameters during block processing.
  • Improved parameters management system with a new subspace for consensus parameters.

• Bug Fixes

  • Refined upgrade testing logic for more immediate upgrade application and better block processing simulation.

• Documentation

  • Updated logging message for proposal status to improve clarity.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes enhance error handling and logging in the application. Key improvements include robust management of consensus parameters during block processing, improved upgrade testing logic with immediate upgrade applications, and clearer logging messages for proposal status in governance. These updates collectively strengthen the application's resilience and clarity, ensuring smoother operations and better diagnostics.

Changes

File	Summary
app/app.go, app/keepers/keepers.go	Introduced checks for consensus parameters, adding subspace for baseapp.Paramspace to improve parameter management.
app/upgrade_test.go	Refined upgrade testing logic, adjusting upgrade timing and ensuring correct block handling without panics.
app/upgrades/v7/upgrade.go	Changed subspace retrieval method for parameters to enhance error handling and removed unnecessary import.
x/gov/keeper/abci.go	Updated logging message for proposal deletion to improve clarity without changing functionality.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant ParamsKeeper
    participant ModuleManager
    participant UpgradeHandler
    participant Logger

    App->>ParamsKeeper: Check consensus parameters
    ParamsKeeper-->>App: Return consensus params (or nil)
    App->>ModuleManager: Begin block processing
    ModuleManager-->>App: Handle block
    App->>Logger: Log proposal status

Loading

🐇 "In the code, changes abound,
With upgrades made, we leap and bound.
Parameters handled with care anew,
Clear logs delight, as we hop through!
Robustness reigns in our little patch,
A vibrant app, a joyful batch!" 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.