fix: data prune-compact cmd home

[zakir-code]

Summary by CodeRabbit

• New Features

  • Improved command execution flow by integrating root command pre-run logic with the data pruning command.

• Bug Fixes

  • Resolved issues by ensuring errors are handled promptly during command execution, preventing unintended behavior.

[coderabbitai]

Walkthrough

The recent update enhances the dataPruningCmd command in the server/data.go file by integrating root-level pre-run logic. This change ensures that any essential checks or setups defined at the root command level are executed first, improving command control flow and error handling. As a result, the command behaves more consistently and robustly within the overall command structure.

Changes

File	Change Summary
server/data.go	Modified PersistentPreRunE in dataPruningCmd to call cmd.Root().PersistentPreRunE, ensuring root pre-run logic is executed first.

Poem

In the command's flow, a change we see,
A hop to the root, as swift as can be.
With checks in the lead, no errors to find,
The data prunes clean, oh so well aligned!
🌟🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Caution

Inline review comments failed to post

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 864d8dd and 1502a82.

Files selected for processing (1)

• server/data.go (1 hunks)

Additional comments not posted (1)

server/data.go (1)

68-70: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to dataPruningCmd match the expected behavior with the added pre-run logic.

Verification successful

---

Verified: The function dataPruningCmd is only used within server/data.go, and the pre-run logic is consistently applied within its definition.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `dataPruningCmd` match the expected behavior with the added pre-run logic.

# Test: Search for the function usage. Expect: Only occurrences of the new behavior.
rg --type go -A 5 $'dataPruningCmd'

Length of output: 629

---

Script:

#!/bin/bash
# Search for all calls to `dataPruningCmd` in the codebase
rg --type go 'dataPruningCmd\(\)'

Length of output: 124

Comments failed to post (1)

server/data.go

68-70: Ensure root-level pre-run logic is non-nil.

The added code assumes cmd.Root().PersistentPreRunE is non-nil. If it is nil, this will cause a runtime panic. Consider adding a nil check.

+			if cmd.Root().PersistentPreRunE != nil {
				if err := cmd.Root().PersistentPreRunE(cmd, args); err != nil {
					return err
				}
+			}

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

			if cmd.Root().PersistentPreRunE != nil {
				if err := cmd.Root().PersistentPreRunE(cmd, args); err != nil {
					return err
				}
			}