fix: update DelegateValidator address during ReDelegate

[zakir-code]

Summary by CodeRabbit

• New Features

  • Enhanced the redelegation functionality to ensure the oracle updates with the new validator address during redelegation processes. This improvement will allow for more accurate interactions with validator data.

• Bug Fixes

  • Addressed an issue with the ReDelegate function to ensure proper updating of the oracle's validator information.

[coderabbitai]

Walkthrough

The recent changes enhance the ReDelegate function in the MsgServer, updating the DelegateValidator within the oracle object to reflect the new ValidatorAddress from incoming messages. This ensures that the oracle remains aligned with the current validator during redelegation, potentially improving its interaction with validator data in future operations.

Changes

Files	Change Summary
x/crosschain/keeper/msg_server.go	Modified the ReDelegate function to update the DelegateValidator in the oracle object with ValidatorAddress and invoke SetOracle.

Poem

🐇 In fields where validators dance and play,
A rabbit hops with joy today!
“ReDelegate!” it calls with glee,
New addresses set, oh what a spree!
The oracle shines, its role anew,
In crosschain realms, the magic grew! ✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9bf195a and 171403c.

Files selected for processing (1)

• x/crosschain/keeper/msg_server.go (1 hunks)

Additional comments not posted (1)

x/crosschain/keeper/msg_server.go (1)

223-224: Ensure the update of DelegateValidator is consistent.

The update to oracle.DelegateValidator and the subsequent call to SetOracle ensure that the oracle's state reflects the new validator address. This change appears correct and necessary for maintaining consistency in the oracle's state during redelegation.

However, verify that this update aligns with the rest of the system's logic and that no additional updates are required elsewhere in the codebase to accommodate this change.

Verification successful

---

Update to DelegateValidator is consistent across the codebase.

The update to DelegateValidator in the ReDelegate function is consistent with its usage in other parts of the codebase. The relevant tests confirm its correct assignment, and the protobuf definitions ensure proper serialization. No further updates are needed elsewhere in the codebase.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the update to `DelegateValidator` is consistent across the codebase.

# Test: Search for usage of `DelegateValidator`. Expect: Consistent logic across the codebase.
rg --type go -A 5 $'DelegateValidator'

Length of output: 6037