-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix show_validator_vote sctipt function #646
Conversation
WalkthroughThe changes enhance the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Script
participant API
User->>Script: Call show_validator_vote(PROPOSAL_ID)
Script->>API: Fetch proposals (v1)
API-->>Script: Return proposal data
Script->>API: Fetch bonded validators
API-->>Script: Return bonded validators
Script->>User: Display formatted output
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- contrib/scripts/run.sh (1 hunks)
Additional comments not posted (3)
contrib/scripts/run.sh (3)
148-153
: Improved output formatting withprintf
.The use of
printf
for output formatting enhances readability and structure. This change is beneficial for maintaining consistent column alignment and applying color formatting to the header row.
154-154
: Filter validators to bonded status.The API call now filters for bonded validators using
status=BOND_STATUS_BONDED
. This change optimizes the data retrieval process by focusing only on relevant validators.
139-139
: EnsurePROPOSAL_ID
is passed correctly.The
PROPOSAL_ID
is now a required argument for the function. Ensure that this change is documented and that all calls to this function provide the necessary argument.
Summary by CodeRabbit
New Features
Improvements
printf
for better readability and visual appeal.PROPOSAL_ID
for better function logic clarity.