Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bower and/or NPM availability #3

Open
yuhunglin opened this issue Feb 6, 2015 · 8 comments
Open

Bower and/or NPM availability #3

yuhunglin opened this issue Feb 6, 2015 · 8 comments

Comments

@yuhunglin
Copy link

Now that this repo's public, probably makes sense to publish.

@sgerrand
Copy link
Contributor

sgerrand commented Feb 6, 2015

Bower, yes; npm doesn't make sense though, as this does not contain
JavaScript.

@igoratron
Copy link
Contributor

I think the general consensus among @FundingCircle/frontend people is there is no real reason why we should not be using npm for this. npm does already contain non javascript assets (e.g. bootstrap) and with their commitment to making npm an even more frontend friendly repository, there're few (if any) compelling arguments why we should use bower.

@yuhunglin
Copy link
Author

Almost forgot about this issue 😄 It'd be handy to be able to stick with just one, multiple dependency management tools makes life not so great. @igoratron @paddyo @sgerrand Does it make sense to rally around publishing this up to NPM?

@sgerrand
Copy link
Contributor

sgerrand commented Jun 9, 2015

@yuhunglin: Do we need to publish this package to npm? It can be pulled from a git:// or https:// URL.

@sgerrand
Copy link
Contributor

sgerrand commented Jun 9, 2015

@igoratron: Will you or someone else in @FundingCircle/frontend take ownership of moving frontend assets from bower to npm?

@igoratron
Copy link
Contributor

I can but I am not sure if we need to do that at the moment. The current setup works and I don't think consolidating the frontend assets under npm has any significant benefits. We'll probably just slowly move to npm as we go and refactor current apps (during the borrower refactor for example) but I don't think this has a high priority.

As for publishing to npm, I am not too keen on that. What would be the benefit? I feel this repository contains components that are very specific to FC and offers very little to outside developers.

@sgerrand
Copy link
Contributor

sgerrand commented Jun 9, 2015

I feel this repository contains components that are very specific to FC and offers very little to outside developers.

Agreed. Hosting on GitHub is more than enough.

@yuhunglin
Copy link
Author

👍 I can't remember the context on why I brought this up in publishing it to NPM so Github only hosting sounds good to me. Can we consolidate on NPM then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants