-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all @extends #77
Comments
ping @FundingCircle/frontend - to keep in mind when using the |
As a SASS/CSS layman I'd like to have a graph that tracks the size of the CSS over time. If it suddenly explodes it would be easier to notice |
@igoratron - you should always check the result of your CSS after you compile Sass. One does not simply write Sass without checking the result, either through a graph or manually. |
Agreed, however at the moment it's not really easy. Or even enforced. Having a graph/test on CI to check if we're not braking this rule would make it easier for me. It might be just me thought -- I think we should graph a lot more :) |
Some
@extends
are a bit vague and generate bad CSS that is hard to control.We should only placeholders and placeholder structures and not classes.
Reason:
will output:
The text was updated successfully, but these errors were encountered: