Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all @extends #77

Open
RazvanDH opened this issue Jul 20, 2015 · 4 comments
Open

Fix all @extends #77

RazvanDH opened this issue Jul 20, 2015 · 4 comments

Comments

@RazvanDH
Copy link
Contributor

Some @extends are a bit vague and generate bad CSS that is hard to control.
We should only placeholders and placeholder structures and not classes.

Reason:

.btn { ... }
.btn--large { @extend .btn; }
...
.funky-element .btn { ... }

will output:

.btn, 
.btn--large { 
  ... 
}
.funky-element .btn,
.funky-element .btn--large {
  ...
}
@RazvanDH
Copy link
Contributor Author

ping @FundingCircle/frontend - to keep in mind when using the @extend

@igoratron
Copy link
Contributor

As a SASS/CSS layman I'd like to have a graph that tracks the size of the CSS over time. If it suddenly explodes it would be easier to notice

@RazvanDH
Copy link
Contributor Author

@igoratron - you should always check the result of your CSS after you compile Sass. One does not simply write Sass without checking the result, either through a graph or manually.

@igoratron
Copy link
Contributor

Agreed, however at the moment it's not really easy. Or even enforced. Having a graph/test on CI to check if we're not braking this rule would make it easier for me. It might be just me thought -- I think we should graph a lot more :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants