Leave config file only for general importers #463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420
Description
Context: When creating the general csv importer, there was a need for a configuration file where to specify how to interpret the dataset and other info so it could be used in the DC data structure (see example). At the time, we decided that it made sense to have a configuration file for each importer not only the general ones. This way we could leave to the user the decision of personalising the built-in importer via the config file. This meant of course changes in the present importers we did not implement. What seemed to be a good design decision at the time (might still be) was not adopted in practice.
In this PR I left the config file only for the general importers and removed it from the rest. I created an Abstract class to represent the importers that have config files so it should be ok if we want it for future importers.
Checklist
Created new test(s) (if applicable)Updated the README / documentation (if applicable)