Space syntax importer #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya-hemanshu
requested review from
lorenaqendro
and removed request for
arya-hemanshu
lorenaqendro
approved these changes
Mar 14, 2018
| * The full dataset can be found at https://github.com/spacesyntax/OpenMapping | ||
| * Please see https://github.com/spacesyntax/OpenMapping for code of conduct and terms of use. | ||
| * | ||
| * How to use in a recipe: |
There was a problem hiding this comment.
Other info missing, subjectType, provider etc
| if exists it updates else adds, but that increase overhead and compute time. | ||
| Using this method will only keep the old value and discard the new one, in case of | ||
| duplicate records. | ||
| Fix Me: Need to find a better way to address it |
There was a problem hiding this comment.
Please, add a FIXME tag here so we can get it easily from the IDE and add an issue for it.
| fixedValue.getId().getAttribute().getLabel(), | ||
| e.getMessage()); | ||
| } | ||
| if ( saved % 2000 == 0 ) { |
There was a problem hiding this comment.
add a short comment of why 2000. It will be useful when rethinking this method as per FIXME.
| private int subjectCount, timedValueCount, fixedValueCount = 0; | ||
|
|
||
| private enum DatasourceId { | ||
| SpaceSyntaxOpenMapping(new DatasourceSpec( |
There was a problem hiding this comment.
could be shorter SSxOpenMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
added space syntax Open Mapping importer
Checklist