A lot of refactoring, and etc #232
Conversation
|
Wait, I forgot to check if any renamed function is used outside the file. I'll convert to draft |
|
It seems no functionality should break after renaming, AFAIK |
|
I need to do more refactoring and solve the commit incompatibility. Converting to draft |
|
(whoops sorry) |
|
It's okay. I realized I made a mistake in the formatting. For example, I found an if (...) {
...
}
else {
...
}And I thought it was a whitespace typo because it looked weird and unique, but then I found it's actually a pattern found in many places lol |
oh this is always how i've done it, pls dont change |
|
lmao, I was using a VScode extension to edit repos remotely without cloning, and I thought I had to type the branch name everytime I wanted to commit. Sorry for any confusion to everyone. Now the commits are named using unhelpful names |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| app.use('/iconkit', express.static(__dirname + '/iconkit')); | ||
| app.get("/global.js", function(req, res) { res.status(200).sendFile(__dirname + "/misc/global.js") }) | ||
| app.use('/iconkit', express.static(__dirname + '/iconkit')) | ||
| app.get("/misc/global.js", function(req, res) { res.status(200).sendFile(__dirname + "/misc/global.js") }) |
Check failure
Code scanning / CodeQL
Missing rate limiting
| }) | ||
|
|
||
| function sendHTML(dir, name) { | ||
| app.get("/" + dir, function(req, res) { res.status(200).sendFile(`${__dirname}/html/${name || dir}.html`) }) |
Check failure
Code scanning / CodeQL
Missing rate limiting
|
I think this PR is too big now. I'll re-review to see if I made more mistakes, and only fix those mistakes in this PR. Any further changes will be done in a separate PR |
| @@ -17,7 +17,6 @@ | |||
| [ "Cool", 37, 20, 17, 1 ], | |||
| [ "Cyclic", 30, 3, 12, 0 ], | |||
| [ "DanZmeN", 104, 34, 12, 1 ], | |||
| [ "DanZmeN", 104, 34, 12, 1 ], | |||
There was a problem hiding this comment.
DanZmeN was duped lol
|
I'm reverting those URLs because I didn't test if they work |
Replaced `var` by `let`, and splitted 1 line. At `sortObj`
Fixes #246
The title is self-descriptive. I also renamed misleading names of functions, and activated JS strict mode.
I made small style changes, like making 1-liner functions actually use 1 line, and splitting long lines of property access into multiple lines for easier reading