Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mean position as metadata instead of user-defined position? #124

Closed
PennyHow opened this issue Apr 12, 2023 · 1 comment
Closed

Mean position as metadata instead of user-defined position? #124

PennyHow opened this issue Apr 12, 2023 · 1 comment
Labels
L1 Issues with L1 data L2 Issues with L2 data

Comments

@PennyHow
Copy link
Member

We preference using the user-defined latitude and longitude information (defined in the station config .toml file) in the metadata.

if hasattr(ds, 'latitude') and hasattr(ds, 'longitude'):
lat = ds.attrs['latitude'] # TODO Why is mean GPS lat lon not preferred for calcs?
lon = ds.attrs['longitude']
else:
lat = ds['gps_lat'].mean()
lon = ds['gps_lon'].mean()

However, it may be better to use the mean latitude and longitude from the dataset. Would this affect the metadata drastically?

@PennyHow PennyHow added L1 Issues with L1 data L2 Issues with L2 data labels Apr 12, 2023
@BaptisteVandecrux BaptisteVandecrux linked a pull request Jun 4, 2024 that will close this issue
@BaptisteVandecrux
Copy link
Member

Since #294, mean latitude/longitude/altitude are now stored as an attribute in the NetCDF files. The metadata files AWS_sites_metadata.csv and AWS_stations_metadata.csv now contain installation and last valid coordinates. Feel free to reopen if this should be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L1 Issues with L1 data L2 Issues with L2 data
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants