feat(orders): add support for Hubble ordering system #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PimVanLeeuwen and @SuperVK please let me know whether the endpoints described in the OpenAPI spec are something you can work with! |
|
I have asked Christiaan from Hubble who will implement the API on the register side and he will take a look at this PR for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new module that implements the ordering system for Hubble. It's goal is to receive order numbers and show them for a certain amount of time on all screen clients. New orders are sent to Aurora using an HTTP endpoint. Then, every time an order is added or manually removed, Aurora sends a SocketIO message to all screen clients with the complete list of all order numbers. Each order number also includes the creation time and after how many seconds the order should be hidden. Note that Aurora Core does not send a message when an order number is expired: the screen clients should hide these themselves after their expiry (to save network resources and server side complexity).
The list of orders is not persistent: it is stored in memory.
Related issues/external references
Types of changes