Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change healthcheck for PHPStan GA workflow #1659

Closed
tomudding opened this issue Jun 29, 2023 · 0 comments · Fixed by #1660
Closed

Change healthcheck for PHPStan GA workflow #1659

tomudding opened this issue Jun 29, 2023 · 0 comments · Fixed by #1660

Comments

@tomudding
Copy link
Member

The PHPStan GA workflow has been failing for some time. I initially thought this was because MariaDB would kill the temporary server which broke our healthcheck. However, the real reason is that the Docker image has been changed and mysqladmin is no longer included, see https://mariadb.org/mariadb-server-docker-official-images-healthcheck-without-mysqladmin/.

This is frustrating to say the least, as this was of course not (clearly) communicated (MariaDB 11.0.1 release notes, which refers to the 11.0.0 release notes where this was not mentioned).

Proposed fix (I have also increased the health retries by two):

                options: --health-cmd="/usr/local/bin/healthcheck.sh --innodb_initialized" --health-interval=10s --health-timeout=5s --health-retries=5

The healthcheck.sh should not need --su-mysql --connect as these are the default options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant