Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck in product overview #64

Open
MaikoCheng opened this issue Nov 6, 2023 · 2 comments
Open

Stuck in product overview #64

MaikoCheng opened this issue Nov 6, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@MaikoCheng
Copy link

When pressing the "X" in the product overview when clicking the product, the window does not close. This is at least the case for C1164 but also for other contracts. Link: https://parelpracht.gewis.nl/contract/1164/product/3357#products

Naamloos

@Yoronex
Copy link
Member

Yoronex commented Nov 7, 2023

This happens because clicking the "X" button actually goes back one page in the browser's history. If you visit this link directly (e.g. by opening it in a new tab), there is nothing to go back to. It is something to take a closer look at how this can be fixed.

@Gijsdeman
Copy link
Contributor

When moving some parts to functional components, I noticed that some of the modals are not very "reusable". To fix that issue with this one together, we can supply a close function that does not go back, but navigates back to the correct page instead.

@Gijsdeman Gijsdeman added the enhancement New feature or request label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants