-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sales-report-service #263
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustSamuel
force-pushed
the
feature/sales-report-service
branch
2 times, most recently
from
August 20, 2024 16:40
d3e1876
to
b75b5e3
Compare
Merged
JustSamuel
force-pushed
the
feature/sales-report-service
branch
2 times, most recently
from
August 23, 2024 22:50
ecd1b92
to
6adadc6
Compare
Yoronex
requested changes
Aug 24, 2024
JustSamuel
force-pushed
the
feature/sales-report-service
branch
from
August 28, 2024 14:16
439dc02
to
1662135
Compare
Yoronex
approved these changes
Aug 29, 2024
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a new Sales Reporting function, as described in #260 and marked as a TODO here #259.
This is SO much faster. It is not even funny, aggregating the whole database is instant. This is because the new service writes queries instead of fetching data and computing the statistics itself. This is how it should always have but the previous reporting function got some scope creep to try and make it more versatile.
This leaves the old reporting untouched, for backwards compatability.
Related issues/external references
Types of changes