Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Clean up components #228

Open
3 tasks
JustSamuel opened this issue Jun 23, 2024 · 1 comment
Open
3 tasks

[Refactor] Clean up components #228

JustSamuel opened this issue Jun 23, 2024 · 1 comment
Labels
For: Dashboard Priority: Low Type: Code quality

Comments

@JustSamuel
Copy link
Contributor

JustSamuel commented Jun 23, 2024 •
edited by CodeNamedRobin
Loading

Some components, such as the ChangeInfoComponent.vue seems to be unused.

Other components, mostly views, should be split into components. IMHO views should not contain core functionality.
See the FineView.vue for example.

  • DataTable in AdminUserOverview.vue
  • FineHandoutComponent in FineView.vue
  • FineHandoutEventsTable in FineView.vue
@CodeNamedRobin CodeNamedRobin mentioned this issue Aug 26, 2024
Merged
@CodeNamedRobin
Copy link
Contributor

CodeNamedRobin commented Aug 30, 2024 •
edited
Loading

As of #314:

  • AdminSingleView has less functional code in there now.
  • ChangeInfoComponent has been removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
For: Dashboard Priority: Low Type: Code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JustSamuel @CodeNamedRobin @SuperVK