Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and restructure classes and packages #125

Open
bonaparten opened this issue Feb 16, 2021 · 2 comments
Open

Rename and restructure classes and packages #125

bonaparten opened this issue Feb 16, 2021 · 2 comments
Labels
brainstorming Idea for a potential new feature or adaption that still needs further discussion code quality Topics around code quality, e.g. refactoring, better naming of methods/classes comments welcome Indicates that the creator of this issue/PR is open for early review comments priority:low Should be quite a far way down on the agenda
Milestone
2.0

Comments

@bonaparten
Copy link
Contributor

A general review of all classes' and packages' names and structures would be useful.

For example, AggregateRequestExecutor.java and DataRequestExecutor.java could be renamed to AggregationRequestExecutor.java and ExtractionRequestExecutor.java. So these classes will follow the same naming criteria used in other packages, i.e. in the package output: DefaultAggregationResponse.java and ExtractionResponse.java .
@bonaparten bonaparten added the brainstorming Idea for a potential new feature or adaption that still needs further discussion label Feb 16, 2021
@bonaparten bonaparten added this to the 2.0 milestone Feb 16, 2021
@bonaparten bonaparten added code quality Topics around code quality, e.g. refactoring, better naming of methods/classes comments welcome Indicates that the creator of this issue/PR is open for early review comments labels Feb 16, 2021
@FabiKo117
Copy link
Contributor

I agree, it would definitely make sense to review again the current structures and names. After we've merged #124 and #121 we can think about which other classes and packages would need to be renamed/restructured.

@FabiKo117 FabiKo117 modified the milestones: 2.0, 1.5 Apr 14, 2021
@FabiKo117 FabiKo117 added the priority:low Should be quite a far way down on the agenda label Apr 14, 2021
@joker234 joker234 modified the milestones: 1.5, 1.6 Jun 22, 2021
@bonaparten
Copy link
Contributor Author

I pushed this old commit. It is an example of how we can restructure some packages and classes.

@tyrasd tyrasd removed this from the 1.6 milestone Aug 3, 2021
@bonaparten bonaparten added this to the 2.0 milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brainstorming Idea for a potential new feature or adaption that still needs further discussion code quality Topics around code quality, e.g. refactoring, better naming of methods/classes comments welcome Indicates that the creator of this issue/PR is open for early review comments priority:low Should be quite a far way down on the agenda
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@tyrasd @joker234 @FabiKo117 @bonaparten