Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property 'contributionTypes' to 'properties' parameter #136

Closed
FabiKo117 opened this issue Feb 19, 2021 · 1 comment · Fixed by #162
Closed

Add property 'contributionTypes' to 'properties' parameter #136

FabiKo117 opened this issue Feb 19, 2021 · 1 comment · Fixed by #162
Labels
enhancement New feature or request
Milestone

Comments

@FabiKo117
Copy link
Contributor

Currently, the @contributionType field gets added to the response features of the /contributions/{geometryType} endpoints if the properties=metadata parameter is given in the request. However, as it is not directly related to the other fields that get added via setting this parameter, it would be better to have it as a distinct value of the properties parameter, so that it gets added via setting properties=contributionTypes (or alternatively contribution types). This property should only be allowed for the /contributions/{geometryType} endpoint.

@FabiKo117 FabiKo117 added enhancement New feature or request code quality Topics around code quality, e.g. refactoring, better naming of methods/classes labels Feb 19, 2021
@FabiKo117 FabiKo117 added this to the 2.0 milestone Feb 19, 2021
@tyrasd tyrasd modified the milestones: 2.0, 1.5 Mar 19, 2021
@tyrasd tyrasd removed the code quality Topics around code quality, e.g. refactoring, better naming of methods/classes label Mar 19, 2021
@tyrasd
Copy link
Member

tyrasd commented Mar 19, 2021

I changed this to milestone 1.5 since the current solution is not very good: It intermingles two different output options: OSM metadata and the contribution type. For backwards compatibility we probably have to stick with the side effect of metadata enabling the contribution type output. I 2.0 we can think about deprecating it, so that metadata only returns metadata :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants