From 710e392e67922c35d11651ad706cd8372a501af6 Mon Sep 17 00:00:00 2001
From: marq24 <marquardt24@gmail.com>
Date: Sun, 26 Jan 2020 10:24:13 +0100
Subject: [PATCH 1/6] added export format tcx (incl. pace in kmh)

---
 .../ors-export-route/ors-export-route.html    |  8 ++
 .../ors-export-route/ors-export-route.js      | 16 +++-
 app/index.html                                |  1 +
 .../ors-importexport-service.js               | 89 +++++++++++++++++++
 app/languages/de-DE.json                      |  3 +-
 app/languages/en-GB.json                      |  3 +-
 app/languages/en-US.json                      |  3 +-
 app/languages/es-ES.json                      |  3 +-
 app/languages/fr-FR.json                      |  3 +-
 app/languages/hu-HU.json                      |  3 +-
 app/languages/id-ID.json                      |  3 +-
 app/languages/it-IT.json                      |  3 +-
 app/languages/pl-PL.json                      |  3 +-
 app/languages/pt-PT.json                      |  3 +-
 app/languages/ru-RU.json                      |  3 +-
 app/languages/zh-CN.json                      |  3 +-
 16 files changed, 137 insertions(+), 13 deletions(-)

diff --git a/app/components/ors-panel-routing/ors-export-route/ors-export-route.html b/app/components/ors-panel-routing/ors-export-route/ors-export-route.html
index 2790cd9c..cdb49bb2 100755
--- a/app/components/ors-panel-routing/ors-export-route/ors-export-route.html
+++ b/app/components/ors-panel-routing/ors-export-route/ors-export-route.html
@@ -55,6 +55,14 @@ <h1 ng-bind-html="('DOWNLOAD_ROUTE' | translate)">
             </div>
         </div>
     </div>
+    <div ng-if="$ctrl.tcxOptShow">
+        <br>
+        <label ng-bind-html="('PACE_SPEED_INKMH' | translate)">
+        </label>
+        <div class="ui input">
+            <input ng-model="$ctrl.speedInKmh" required="" select-on-click="" type="number" step="0.1" min="1" max="50">
+        </div>
+    </div>
     <div class="ui divider">
     </div>
     <button class="ui mini button" ng-bind-html="('DOWNLOAD' | translate)" ng-click="$ctrl.exportRoute()">
diff --git a/app/components/ors-panel-routing/ors-export-route/ors-export-route.js b/app/components/ors-panel-routing/ors-export-route/ors-export-route.js
index b7c74ff0..89c8156d 100755
--- a/app/components/ors-panel-routing/ors-export-route/ors-export-route.js
+++ b/app/components/ors-panel-routing/ors-export-route/ors-export-route.js
@@ -11,6 +11,7 @@ angular
         ctrl.elevation = true;
         ctrl.instructions = false;
         ctrl.toGpx = true;
+        ctrl.speedInKmh = 9.5;
         ctrl.filename = "ors-export-linestring";
         ctrl.gpxOptShow = true;
         ctrl.tcxOptShow = false;
@@ -26,6 +27,10 @@ angular
             text: "Keyhole Markup Language (.kml)",
             value: "kml"
           },
+          {
+            text: "GarminTCX (.tcx)",
+            value: "tcx"
+          },
           {
             text: "GeoJSON (.geojson)",
             value: "geojson"
@@ -90,9 +95,11 @@ angular
           let options = {
             elevation: ctrl.elevation,
             instructions: ctrl.instructions,
-            toGpx: ctrl.toGpx
+            toGpx: ctrl.toGpx,
+            speedInKmh: ctrl.speedInKmh
           };
           let currentRoute = null;
+          let currentRouteMetaData = null;
           if (ctrl.currentFileFormat === "rawjson") {
             currentRoute =
               orsRouteService.data.features[
@@ -103,9 +110,16 @@ angular
               orsRouteService.data.features[
                 orsRouteService.getCurrentRouteIdx()
               ].geometry;
+            if (ctrl.currentFileFormat === "tcx") {
+              currentRouteMetaData =
+                orsRouteService.data.features[
+                  orsRouteService.getCurrentRouteIdx()
+                ].point_information;
+            }
           }
           orsExportFactory.exportFile(
             currentRoute,
+            currentRouteMetaData,
             "linestring",
             options,
             ctrl.currentFileFormat,
diff --git a/app/index.html b/app/index.html
index c3a061ff..75e3ceca 100755
--- a/app/index.html
+++ b/app/index.html
@@ -103,6 +103,7 @@
 <script src="bower_components/angular-translate-loader-static-files/angular-translate-loader-static-files.js"></script>
 <script src="node_modules/@angular/router/angular1/angular_1_router.js"></script>
 <script src="node_modules/geojson/geojson.min.js"></script>
+<script src="node_modules/jxon/jxon.js"></script>
 <script src="node_modules/togpx/togpx.js"></script>
 <script src="node_modules/xml-js/dist/xml-js.min.js"></script>
 <script src="node_modules/tokml/tokml.js"></script>
diff --git a/app/infrastructure/ors-importexport-service.js b/app/infrastructure/ors-importexport-service.js
index b22798a9..ba4dbc99 100755
--- a/app/infrastructure/ors-importexport-service.js
+++ b/app/infrastructure/ors-importexport-service.js
@@ -76,6 +76,91 @@ angular
         );
       };
 
+      // create a simple Course TCX file (MARQ24)
+      // see https://www8.garmin.com/xmlschemas/TrainingCenterDatabasev2.xsd
+      let totcx = (name, metadata, speedInKmh) => {
+        var tcx = {
+          TrainingCenterDatabase: {
+            "@xsi:schemaLocation":
+              "http://www.garmin.com/xmlschemas/TrainingCenterDatabase/v2 http://www.garmin.com/xmlschemas/TrainingCenterDatabasev2.xsd",
+            "@xmlns":
+              "http://www.garmin.com/xmlschemas/TrainingCenterDatabase/v2",
+            "@xmlns:xsi": "http://www.w3.org/2001/XMLSchema-instance",
+            Courses: { Course: [] }
+          }
+        };
+
+        var speed = speedInKmh / 3.6; // need to convert in m per sec
+        var coursObj = {
+          Name: name,
+          Lap: {
+            TotalTimeSeconds: "",
+            DistanceMeters: metadata[metadata.length - 1].distance,
+            BeginPosition: {
+              LatitudeDegrees: metadata[0].coords[0],
+              LongitudeDegrees: metadata[0].coords[1]
+            },
+            EndPosition: {
+              LatitudeDegrees: metadata[metadata.length - 1].coords[0],
+              LongitudeDegrees: metadata[metadata.length - 1].coords[1]
+            },
+            Intensity: "Active"
+          },
+          Track: { Trackpoint: [] },
+          Creator: { Name: "OpenRouteService.org" }
+        };
+
+        var lastDistance = 0;
+        var totalTimeInSec = 0;
+        metadata.forEach(function meta(data, i) {
+          if (data.distance !== undefined) {
+            var deltaDistanceInMeter = data.distance - lastDistance;
+            var timeDelta = deltaDistanceInMeter / speed;
+            totalTimeInSec = totalTimeInSec + timeDelta;
+
+            var hour = parseInt(totalTimeInSec / 3600);
+            var totalTimeInSecSubHour = totalTimeInSec - hour * 3600;
+            var hourS = hour + "";
+
+            var minS = parseInt(totalTimeInSecSubHour / 60) + "";
+            var secS = parseInt(totalTimeInSecSubHour % 60) + "";
+            var msS = (totalTimeInSecSubHour % 60).toFixed(3) + "";
+
+            if (hourS.length == 1) {
+              hourS = "0" + hourS;
+            }
+            if (minS.length == 1) {
+              minS = "0" + minS;
+            }
+            if (secS.length == 1) {
+              msS = "0" + msS;
+            }
+            var tp = {
+              Time: "2010-01-01T" + hourS + ":" + minS + ":" + msS + "Z",
+              Position: {
+                LatitudeDegrees: data.coords[0],
+                LongitudeDegrees: data.coords[1]
+              }
+            };
+            if (
+              data.heights !== undefined &&
+              data.heights.height !== undefined
+            ) {
+              tp.AltitudeMeters = data.heights.height;
+            }
+            tp.DistanceMeters = data.distance;
+            lastDistance = data.distance;
+            coursObj.Track.Trackpoint.push(tp);
+          }
+        });
+        coursObj.Lap.TotalTimeSeconds = totalTimeInSec.toFixed(1);
+        tcx.TrainingCenterDatabase.Courses.Course.push(coursObj);
+
+        JXON.config({ attrPrefix: "@" });
+        var tcx_str = JXON.stringify(tcx);
+        return '<?xml version="1.0" encoding="UTF-8"?>' + tcx_str;
+      };
+
       let orsExportFactory = {};
       /**
        * Export any vector element on the map to file
@@ -87,6 +172,7 @@ angular
        */
       orsExportFactory.exportFile = (
         geometry,
+        metadata,
         geomType,
         options,
         format,
@@ -110,6 +196,9 @@ angular
             geojsonData = L.polyline(geometry).toGeoJSON();
             exportData = tokml(geojsonData);
             break;
+          case "tcx":
+            exportData = totcx(filename, metadata, options.speedInKmh);
+            break;
           case "rawjson":
             // removing nodes from the geometry data that is for sure not needed
             // by 3'rd party...
diff --git a/app/languages/de-DE.json b/app/languages/de-DE.json
index 9fb42e23..184f1f8e 100755
--- a/app/languages/de-DE.json
+++ b/app/languages/de-DE.json
@@ -230,5 +230,6 @@
     "ROUNDTRIP_PREVIOUS": "Letzter Rundweg",
     "ROUNDTRIP_NEXT": "Nächster Rundweg",
     "ROUNDTRIP": "Rundweg (experimentell)",
-    "ROUNDTRIP_DO": "Rundweg generieren"
+    "ROUNDTRIP_DO": "Rundweg generieren",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/en-GB.json b/app/languages/en-GB.json
index ae5aa9ba..2b289e1d 100755
--- a/app/languages/en-GB.json
+++ b/app/languages/en-GB.json
@@ -230,5 +230,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/en-US.json b/app/languages/en-US.json
index ae5aa9ba..2b289e1d 100755
--- a/app/languages/en-US.json
+++ b/app/languages/en-US.json
@@ -230,5 +230,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/es-ES.json b/app/languages/es-ES.json
index 84d61928..3458c754 100755
--- a/app/languages/es-ES.json
+++ b/app/languages/es-ES.json
@@ -229,5 +229,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/fr-FR.json b/app/languages/fr-FR.json
index 5155b72e..88b959b4 100755
--- a/app/languages/fr-FR.json
+++ b/app/languages/fr-FR.json
@@ -229,5 +229,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/hu-HU.json b/app/languages/hu-HU.json
index 64d3a71f..1236cc6c 100755
--- a/app/languages/hu-HU.json
+++ b/app/languages/hu-HU.json
@@ -230,5 +230,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/id-ID.json b/app/languages/id-ID.json
index 7e9d9584..001cffd2 100644
--- a/app/languages/id-ID.json
+++ b/app/languages/id-ID.json
@@ -230,5 +230,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/it-IT.json b/app/languages/it-IT.json
index 1dd01da9..41f0dc03 100644
--- a/app/languages/it-IT.json
+++ b/app/languages/it-IT.json
@@ -230,5 +230,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/pl-PL.json b/app/languages/pl-PL.json
index 55a78874..70aa44a8 100755
--- a/app/languages/pl-PL.json
+++ b/app/languages/pl-PL.json
@@ -229,5 +229,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/pt-PT.json b/app/languages/pt-PT.json
index 7bd284d4..5b39eaab 100755
--- a/app/languages/pt-PT.json
+++ b/app/languages/pt-PT.json
@@ -229,5 +229,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/ru-RU.json b/app/languages/ru-RU.json
index 9402c83c..75b36c5c 100755
--- a/app/languages/ru-RU.json
+++ b/app/languages/ru-RU.json
@@ -230,5 +230,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }
diff --git a/app/languages/zh-CN.json b/app/languages/zh-CN.json
index e8288bda..91e830f2 100755
--- a/app/languages/zh-CN.json
+++ b/app/languages/zh-CN.json
@@ -229,5 +229,6 @@
     "ROUNDTRIP_PREVIOUS": "Previous round trip",
     "ROUNDTRIP_NEXT": "Next round trip",
     "ROUNDTRIP": "Round trip (experimental)",
-    "ROUNDTRIP_DO": "Do round trip"
+    "ROUNDTRIP_DO": "Do round trip",
+    "PACE_SPEED_INKMH": "Pace in km/h"
 }

From 5d79775873e8d561cb575c8837e7b2fac181d668 Mon Sep 17 00:00:00 2001
From: marq24 <marquardt24@gmail.com>
Date: Sun, 26 Jan 2020 13:08:39 +0100
Subject: [PATCH 2/6] fixed Creator Info - thanks for nothing garmin

---
 app/infrastructure/ors-importexport-service.js | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/app/infrastructure/ors-importexport-service.js b/app/infrastructure/ors-importexport-service.js
index ba4dbc99..1ded9eeb 100755
--- a/app/infrastructure/ors-importexport-service.js
+++ b/app/infrastructure/ors-importexport-service.js
@@ -107,7 +107,23 @@ angular
             Intensity: "Active"
           },
           Track: { Trackpoint: [] },
-          Creator: { Name: "OpenRouteService.org" }
+          Creator: {
+            "@xsi:type": "Application_t",
+            Name: "OpenRouteService.org",
+            Build: {
+              Version: {
+                VersionMajor: "0",
+                VersionMinor: "4",
+                BuildMajor: "1",
+                BuildMinor: "0"
+              },
+              Type: "Release",
+              Time: "Jan 26 2020, 10:00:00",
+              Builder: "mcp"
+            },
+            LangID: "DE",
+            PartNumber: "ORS-00410-DE" // The formatted XXX-XXXXX-XX Garmin part number of a PC application
+          }
         };
 
         var lastDistance = 0;

From 16bd17c570351232447decdb7c759db5bed2e6bc Mon Sep 17 00:00:00 2001
From: marq24 <marquardt24@gmail.com>
Date: Sun, 26 Jan 2020 17:11:12 +0100
Subject: [PATCH 3/6] cool - if <creator> is set, then Garmin Training Center
 App refuse to transfer a Course to a Forerunner device - so make use of
 <Author>

---
 .../ors-importexport-service.js               | 37 +++++++++----------
 1 file changed, 18 insertions(+), 19 deletions(-)

diff --git a/app/infrastructure/ors-importexport-service.js b/app/infrastructure/ors-importexport-service.js
index 1ded9eeb..b38e606b 100755
--- a/app/infrastructure/ors-importexport-service.js
+++ b/app/infrastructure/ors-importexport-service.js
@@ -86,7 +86,23 @@ angular
             "@xmlns":
               "http://www.garmin.com/xmlschemas/TrainingCenterDatabase/v2",
             "@xmlns:xsi": "http://www.w3.org/2001/XMLSchema-instance",
-            Courses: { Course: [] }
+            Courses: { Course: [] },
+            Author: {
+              "@xsi:type": "Application_t",
+              Name: "OpenRouteService.org",
+              Build: {
+                Version: {
+                  VersionMajor: "0",
+                  VersionMinor: "4",
+                  BuildMajor: "1",
+                  BuildMinor: "0"
+                },
+                Type: "Release",
+                Time: "Jan 26 2020, 10:00:00",
+                Builder: "mcp"
+              },
+              LangID: "DE", PartNumber: "ORS-00410-DE" // The formatted XXX-XXXXX-XX Garmin part number of a PC application
+            }
           }
         };
 
@@ -106,24 +122,7 @@ angular
             },
             Intensity: "Active"
           },
-          Track: { Trackpoint: [] },
-          Creator: {
-            "@xsi:type": "Application_t",
-            Name: "OpenRouteService.org",
-            Build: {
-              Version: {
-                VersionMajor: "0",
-                VersionMinor: "4",
-                BuildMajor: "1",
-                BuildMinor: "0"
-              },
-              Type: "Release",
-              Time: "Jan 26 2020, 10:00:00",
-              Builder: "mcp"
-            },
-            LangID: "DE",
-            PartNumber: "ORS-00410-DE" // The formatted XXX-XXXXX-XX Garmin part number of a PC application
-          }
+          Track: { Trackpoint: [] }
         };
 
         var lastDistance = 0;

From 286c1cc41b63caebf73cc9d416a6ec61e0180e79 Mon Sep 17 00:00:00 2001
From: Amandus Butzer <amandusbutzer@gmx.de>
Date: Mon, 27 Jan 2020 17:03:26 +0100
Subject: [PATCH 4/6] Refactor garmin change

---
 .../ors-export-route/ors-export-route.js      |  8 --
 .../ors-importexport-service.js               | 91 ++++++++-----------
 2 files changed, 37 insertions(+), 62 deletions(-)

diff --git a/app/components/ors-panel-routing/ors-export-route/ors-export-route.js b/app/components/ors-panel-routing/ors-export-route/ors-export-route.js
index 89c8156d..00c85aa0 100755
--- a/app/components/ors-panel-routing/ors-export-route/ors-export-route.js
+++ b/app/components/ors-panel-routing/ors-export-route/ors-export-route.js
@@ -99,7 +99,6 @@ angular
             speedInKmh: ctrl.speedInKmh
           };
           let currentRoute = null;
-          let currentRouteMetaData = null;
           if (ctrl.currentFileFormat === "rawjson") {
             currentRoute =
               orsRouteService.data.features[
@@ -110,16 +109,9 @@ angular
               orsRouteService.data.features[
                 orsRouteService.getCurrentRouteIdx()
               ].geometry;
-            if (ctrl.currentFileFormat === "tcx") {
-              currentRouteMetaData =
-                orsRouteService.data.features[
-                  orsRouteService.getCurrentRouteIdx()
-                ].point_information;
-            }
           }
           orsExportFactory.exportFile(
             currentRoute,
-            currentRouteMetaData,
             "linestring",
             options,
             ctrl.currentFileFormat,
diff --git a/app/infrastructure/ors-importexport-service.js b/app/infrastructure/ors-importexport-service.js
index b38e606b..9ba3703e 100755
--- a/app/infrastructure/ors-importexport-service.js
+++ b/app/infrastructure/ors-importexport-service.js
@@ -78,8 +78,12 @@ angular
 
       // create a simple Course TCX file (MARQ24)
       // see https://www8.garmin.com/xmlschemas/TrainingCenterDatabasev2.xsd
-      let totcx = (name, metadata, speedInKmh) => {
-        var tcx = {
+      let toTcx = (name, speedInKmPerH) => {
+        let version = "0.4.1"
+        let pointInformation = orsRouteService.data.features[orsRouteService.getCurrentRouteIdx()].point_information
+        let appVersion = version.split('.')
+        let garminPartNumber = `ORS-0{$appVersion[0]}{$appVersion[1]}{$appVersion[2]}0-DE`
+        let tcx = {
           TrainingCenterDatabase: {
             "@xsi:schemaLocation":
               "http://www.garmin.com/xmlschemas/TrainingCenterDatabase/v2 http://www.garmin.com/xmlschemas/TrainingCenterDatabasev2.xsd",
@@ -89,90 +93,70 @@ angular
             Courses: { Course: [] },
             Author: {
               "@xsi:type": "Application_t",
-              Name: "OpenRouteService.org",
+              Name: "openrouteservice.org",
               Build: {
                 Version: {
-                  VersionMajor: "0",
-                  VersionMinor: "4",
-                  BuildMajor: "1",
+                  VersionMajor: appVersion[0],
+                  VersionMinor: appVersion[1],
+                  BuildMajor: appVersion[2],
                   BuildMinor: "0"
                 },
                 Type: "Release",
                 Time: "Jan 26 2020, 10:00:00",
                 Builder: "mcp"
               },
-              LangID: "DE", PartNumber: "ORS-00410-DE" // The formatted XXX-XXXXX-XX Garmin part number of a PC application
+              LangID: "DE", PartNumber: garminPartNumber // The formatted XXX-XXXXX-XX Garmin part number of a PC application
             }
           }
         };
 
-        var speed = speedInKmh / 3.6; // need to convert in m per sec
-        var coursObj = {
+        let speedInMPerS = speedInKmPerH / 3.6; // need to convert in m per sec
+        let courseObj = {
           Name: name,
           Lap: {
             TotalTimeSeconds: "",
-            DistanceMeters: metadata[metadata.length - 1].distance,
+            DistanceMeters: pointInformation[pointInformation.length - 1].distance,
             BeginPosition: {
-              LatitudeDegrees: metadata[0].coords[0],
-              LongitudeDegrees: metadata[0].coords[1]
+              LatitudeDegrees: pointInformation[0].coords[0],
+              LongitudeDegrees: pointInformation[0].coords[1]
             },
             EndPosition: {
-              LatitudeDegrees: metadata[metadata.length - 1].coords[0],
-              LongitudeDegrees: metadata[metadata.length - 1].coords[1]
+              LatitudeDegrees: pointInformation[pointInformation.length - 1].coords[0],
+              LongitudeDegrees: pointInformation[pointInformation.length - 1].coords[1]
             },
             Intensity: "Active"
           },
           Track: { Trackpoint: [] }
-        };
-
-        var lastDistance = 0;
-        var totalTimeInSec = 0;
-        metadata.forEach(function meta(data, i) {
+        }
+        let duration
+        for (const data of pointInformation) {
           if (data.distance !== undefined) {
-            var deltaDistanceInMeter = data.distance - lastDistance;
-            var timeDelta = deltaDistanceInMeter / speed;
-            totalTimeInSec = totalTimeInSec + timeDelta;
-
-            var hour = parseInt(totalTimeInSec / 3600);
-            var totalTimeInSecSubHour = totalTimeInSec - hour * 3600;
-            var hourS = hour + "";
-
-            var minS = parseInt(totalTimeInSecSubHour / 60) + "";
-            var secS = parseInt(totalTimeInSecSubHour % 60) + "";
-            var msS = (totalTimeInSecSubHour % 60).toFixed(3) + "";
-
-            if (hourS.length == 1) {
-              hourS = "0" + hourS;
-            }
-            if (minS.length == 1) {
-              minS = "0" + minS;
-            }
-            if (secS.length == 1) {
-              msS = "0" + msS;
-            }
-            var tp = {
-              Time: "2010-01-01T" + hourS + ":" + minS + ":" + msS + "Z",
+            duration = data.distance / speedInMPerS;
+            const seconds = duration.toFixed(3) || 0
+            const milliSeconds = seconds.split('.')[1] || 0
+            let durationDate = new Date(2010,0,1,0,0,seconds, milliSeconds)
+            let tp = {
+              Time: durationDate.toISOString(),
               Position: {
                 LatitudeDegrees: data.coords[0],
                 LongitudeDegrees: data.coords[1]
-              }
-            };
+              },
+              DistanceMeters: data.distance
+            }
             if (
-              data.heights !== undefined &&
+              data.heights &&
               data.heights.height !== undefined
             ) {
               tp.AltitudeMeters = data.heights.height;
             }
-            tp.DistanceMeters = data.distance;
-            lastDistance = data.distance;
-            coursObj.Track.Trackpoint.push(tp);
+            courseObj.Track.Trackpoint.push(tp);
           }
-        });
-        coursObj.Lap.TotalTimeSeconds = totalTimeInSec.toFixed(1);
-        tcx.TrainingCenterDatabase.Courses.Course.push(coursObj);
+        }
+        courseObj.Lap.TotalTimeSeconds = duration.toFixed(1);
+        tcx.TrainingCenterDatabase.Courses.Course.push(courseObj);
 
         JXON.config({ attrPrefix: "@" });
-        var tcx_str = JXON.stringify(tcx);
+        const tcx_str = JXON.stringify(tcx)
         return '<?xml version="1.0" encoding="UTF-8"?>' + tcx_str;
       };
 
@@ -187,7 +171,6 @@ angular
        */
       orsExportFactory.exportFile = (
         geometry,
-        metadata,
         geomType,
         options,
         format,
@@ -212,7 +195,7 @@ angular
             exportData = tokml(geojsonData);
             break;
           case "tcx":
-            exportData = totcx(filename, metadata, options.speedInKmh);
+            exportData = toTcx(filename, options.speedInKmh);
             break;
           case "rawjson":
             // removing nodes from the geometry data that is for sure not needed

From 6738327ff75f552e0833a33e7e0fdcb9ceeeef72 Mon Sep 17 00:00:00 2001
From: Amandus Butzer <amandusbutzer@gmx.de>
Date: Mon, 27 Jan 2020 17:15:34 +0100
Subject: [PATCH 5/6] Fix template string

---
 app/infrastructure/ors-importexport-service.js | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/infrastructure/ors-importexport-service.js b/app/infrastructure/ors-importexport-service.js
index 9ba3703e..9ed16cf6 100755
--- a/app/infrastructure/ors-importexport-service.js
+++ b/app/infrastructure/ors-importexport-service.js
@@ -81,8 +81,8 @@ angular
       let toTcx = (name, speedInKmPerH) => {
         let version = "0.4.1"
         let pointInformation = orsRouteService.data.features[orsRouteService.getCurrentRouteIdx()].point_information
-        let appVersion = version.split('.')
-        let garminPartNumber = `ORS-0{$appVersion[0]}{$appVersion[1]}{$appVersion[2]}0-DE`
+        let [majorV, minorV, patchV] = version.split('.')
+        let garminPartNumber = `ORS-0${majorV}${minorV}${patchV}0-DE`
         let tcx = {
           TrainingCenterDatabase: {
             "@xsi:schemaLocation":
@@ -96,9 +96,9 @@ angular
               Name: "openrouteservice.org",
               Build: {
                 Version: {
-                  VersionMajor: appVersion[0],
-                  VersionMinor: appVersion[1],
-                  BuildMajor: appVersion[2],
+                  VersionMajor: majorV,
+                  VersionMinor: minorV,
+                  BuildMajor: patchV,
                   BuildMinor: "0"
                 },
                 Type: "Release",

From cb17655b4a5443338b8ed3755a31285e522fc821 Mon Sep 17 00:00:00 2001
From: marq24 <marquardt24@gmail.com>
Date: Mon, 27 Jan 2020 19:34:25 +0100
Subject: [PATCH 6/6] - better start @ 12 o'clock (in order to avoid issues
 with local time zones) - <DistanceMeters> Element have to be after a possible
 <AltitudeMeters> as defined in the Schema

---
 app/infrastructure/ors-importexport-service.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/infrastructure/ors-importexport-service.js b/app/infrastructure/ors-importexport-service.js
index 9ed16cf6..4547ddd4 100755
--- a/app/infrastructure/ors-importexport-service.js
+++ b/app/infrastructure/ors-importexport-service.js
@@ -134,14 +134,13 @@ angular
             duration = data.distance / speedInMPerS;
             const seconds = duration.toFixed(3) || 0
             const milliSeconds = seconds.split('.')[1] || 0
-            let durationDate = new Date(2010,0,1,0,0,seconds, milliSeconds)
+            let durationDate = new Date(2010,0,1,12,0,seconds, milliSeconds)
             let tp = {
               Time: durationDate.toISOString(),
               Position: {
                 LatitudeDegrees: data.coords[0],
                 LongitudeDegrees: data.coords[1]
-              },
-              DistanceMeters: data.distance
+              }
             }
             if (
               data.heights &&
@@ -149,6 +148,7 @@ angular
             ) {
               tp.AltitudeMeters = data.heights.height;
             }
+            tp.DistanceMeters = data.distance;
             courseObj.Track.Trackpoint.push(tp);
           }
         }