Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternative_routes together with extra_info will provide wrong extra_info #681

Closed
TheGreatRefrigerator opened this issue Mar 6, 2020 · 0 comments · Fixed by #727
Closed
Assignees
Labels
bug Erroneous behavior of the backend
Milestone

Comments

@TheGreatRefrigerator
Copy link
Contributor

TheGreatRefrigerator commented Mar 6, 2020

Here's what I did

request to
https://api.openrouteservice.org/v2/directions/driving-car/geojson
body:

{"preference":"fastest","language":"en-US","instructions":true,"geometry":true,"units":"m","attributes":["detourfactor","percentage"],"instructions_format":"html","elevation":true,"coordinates":[[8.507195,48.946406],[8.50771,48.953142]],"alternative_routes":{"target_count":3},"extra_info":["steepness","waytype","surface"]}

using alternative_routes and some extra_info value.


Here's what I got

The waypoint number the extra info index refers to (34+) is out of bounds of the coordinates array for the current route (32 points).
grafik

The extras response property for each route contain the segments of all 3 routes if the coordinate arrays of all routes would be merged.


Here's what I was expecting

extras objects should only contain the segments of the route they are placed in.


Here's what I think could be improved

Tests for newly implemented parameters that also cover using the new parameter with existing parameters.

@TheGreatRefrigerator TheGreatRefrigerator added the bug Erroneous behavior of the backend label Mar 6, 2020
@TheGreatRefrigerator TheGreatRefrigerator changed the title alternative_routes togeather with extra_info will provide wrong extra_info alternative_routes together with extra_info will provide wrong extra_info Mar 17, 2020
@takb takb self-assigned this Mar 31, 2020
@takb takb added this to the 6.1.1 milestone May 20, 2020
@takb takb closed this as completed in #727 Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Erroneous behavior of the backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants