OSHEntity Filter

[SlowMo24]

Currently to get non-region-related contribution information (user specific (#170 ), changeset specific, object specific etc.) creates a large overhead of contribution objects, that are then only later filtered in the MapReduce-pipeline. Implementing GridOSHEntityand OSHEntityfilters would reduce computation and memory cost for e.g. user or object based analyses, especially when the area of interest is large.

Would partly address #254 .

[tyrasd]

I think #253 would solve this, actually, at least to some extent: It provides a more flexible method to inject more complex filters than what is currently possible (and IMHO a more elegant interface than to just provide more use-case specific filter methods): MapReducer::filter(FilterExpression f) allows to supply a filter expression object. It was meant to be used primarily with the ohsome filter library, but can be used standalone as well:

  ….filter(new Filter() {
      @Override
      public boolean applyOSM(OSMEntity entity) {
        return true;
      }

      @Override
      public boolean applyOSH(OSHEntity entity) {
        return setOfAllowedIds.contains(entity.getId());
      }

      @Override
      public FilterExpression negate() {
        return null;
      }
    })…

//edit: with something like https://gitlab.gistools.geog.uni-heidelberg.de/giscience/big-data/ohsome/libs/ohsome-filter/-/issues/14 this would be even more elegant:

  ….filter(Filter.byOSHEntity(entity -> setOfAllowedIds.contains(entity.getId())))…

[SlowMo24]

This sounds great 🎉 and #253 seems nearly finished (judging by the checkboxes). When will it get merged?

[tyrasd]

When will it get merged?

when ohsome-filter v1.4 is ready and published. could be soon

[rtroilo]

this is great!