improve performance of building multipolygons with a huge number of member ways #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
added
the
performance
…ember ways This improves performance significantly for multipolygons which have a very large number of outer member ways. Some of them (e.g. 6677259) have > 10k members, which causes slow processing in the `buildRings` (formerly `join`) helper function. In one test, this reduces the geometry building from 6 minutes down to 2.5 seconds for one particularly members heavy multipolygon.
tyrasd
force-pushed
the
performance-wayheavy-multipolygons
branch
from
4507c30
to
5a0fee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance significantly for multipolygons which have a very large number of outer member ways. Some of them (e.g.
relation/6677259) have > 10k members, which causes slow processing in thebuildRings(formerlyjoin) helper function.In one test (with the particularly heavy example from above), this reduces the geometry building from 6 minutes down to 0.5 seconds for one particularly members heavy multipolygon.