Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CellIterater to make SnapshotView more streamable #429

Closed
rtroilo opened this issue Sep 15, 2021 · 0 comments
Closed

Refactor CellIterater to make SnapshotView more streamable #429

rtroilo opened this issue Sep 15, 2021 · 0 comments
Assignees
@rtroilo
Labels
code quality Related to our standards for 'good' code performance Performance optimizations, bottlenecks of the current pipeline, etc.

Comments

@rtroilo
Copy link
Member

rtroilo commented Sep 15, 2021

The PR #428, changes the CellIterator iterateByContribution to use an Iterator approach instead of collecting all Contributions before stream them further down stream.

Similar should be done for the iterateByTimestamps methods.
@rtroilo rtroilo added the code quality Related to our standards for 'good' code label Sep 15, 2021
@rtroilo rtroilo mentioned this issue Sep 15, 2021
Merged
5 tasks
@rtroilo rtroilo self-assigned this Sep 15, 2021
@tyrasd tyrasd added the performance Performance optimizations, bottlenecks of the current pipeline, etc. label Sep 15, 2021
@Hagellach37 Hagellach37 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtroilo rtroilo

Labels
code quality Related to our standards for 'good' code performance Performance optimizations, bottlenecks of the current pipeline, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tyrasd @rtroilo @Hagellach37