cleaning dependencies, remove apache-commons #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
requested changes
Feb 26, 2019
oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/generic/OSHDBCombinedIndex.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/generic/OSHDBCombinedIndex.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/GeometrySplitter.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/GeometrySplitter.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/GeometrySplitter.java
Outdated
Show resolved
Hide resolved
oshdb/src/main/java/org/heigit/bigspatialdata/oshdb/index/XYGrid.java
Outdated
Show resolved
Hide resolved
oshdb/src/main/java/org/heigit/bigspatialdata/oshdb/index/XYGrid.java
Outdated
Show resolved
Hide resolved
oshdb/src/main/java/org/heigit/bigspatialdata/oshdb/util/OSHDBFilter.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/heigit/bigspatialdata/oshdb/util/byteArray/FastByteArrayOutputStream.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/MapAggregator.java
Outdated
Show resolved
Hide resolved
rtroilo
force-pushed
the
clean-oshdb-dep
branch
from
2601470
to
2ff34ae
Compare
and get rid of unnecessary intermediate class "BiIndex"
instead of lists of key/value objects
tyrasd
approved these changes
Feb 26, 2019
There was a problem hiding this comment.
I added a few commits to this: https://github.com/GIScience/oshdb/pull/79/files/2ff34ae5f42173ad218eadb2897b0b5267691e8d..178d4aa09d57b2916f6d65aa2c7d92da082c6cba
The PR now looks good from my side, but maybe you can check these before merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cleaned up the dependency hierarchy and removed the dependency to apache-commons.