Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e9compile fixes #76

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

e9compile fixes #76

wants to merge 6 commits into from

Conversation

milahu
Copy link
Contributor

@milahu milahu commented Feb 6, 2024 •
edited
Loading

fix #75 etc

remove the include path examples/
users should set their own include paths

e9compile foo.c -I bar/

@GJDuck
Copy link
Owner

GJDuck commented Feb 7, 2024

Thanks for interest in cleaning this up. But I think some of the changes are not compatible with older versions of bash, e.g.:

    $ ./e9compile.sh print.c
    ./e9compile.sh: 65: ./e9compile.sh: Syntax error: "(" unexpected

It works fine in newer versions. Generally I'd prefer it works on even very old versions, if there is no pressing reason to use newer features.

@milahu
Copy link
Contributor Author

milahu commented Feb 7, 2024

true, this breaks in posix shells

$ ash e9compile.sh asdf.c
e9compile.sh: line 65: syntax error: unexpected "("

CFLAGS=(

$ mrsh e9compile.sh asdf.c
e9compile.sh:20:10: syntax error: invalid parameter name

    RED=$'\033[31m'

$ yash e9compile.sh asdf.c
e9compile.sh:54: syntax error: invalid character `@' in parameter expansion
e9compile.sh:54: syntax error: `esac' is missing

        echo "${RED}error${OFF}: file ${1@Q} must have a .c/.cpp/.s extension" >&2

the only thing that would work is removing the -I examples/ arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e9compile: remove xargs
2 participants
@milahu @GJDuck