Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: reorg inversion_solution modules #52

Open
7 tasks done
chrisbc opened this issue Oct 22, 2024 · 0 comments
Open
7 tasks done

Feature: reorg inversion_solution modules #52

chrisbc opened this issue Oct 22, 2024 · 0 comments

Comments

@chrisbc
Copy link
Member

chrisbc commented Oct 22, 2024

The current inheritance model used in this package has become difficult to handle and difficult to document well.

Suggested improvements:

  • make *File classes (IS and FSS) members rather than supertypes of the user class.
  • hoist *File methods to the IS and FSS only where necessary.
  • make *Operations classes (IS and FSS) members rather than supertypes of the user class.
  • hoist *Operations methods to the IS and FSS only if necessary..but consider not doing this but forcing users to migrate to new DF member.
  • rename ...Operations classes to Model
  • refactor the type *Protocol module splitting out *File and *Operations into their own classes
  • migrate docstrings into the Protocol classes
  • reorganise tests to align with the new module features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant