Change bad MP moves from error to warning #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregorySchwing
requested changes
Aug 14, 2023
There was a problem hiding this comment.
This won't warn the user in GPU versions of the code. I'd leave the kill variable and use it to print a warning outside of both the Translate CPP function/cuda kernel instead of exiting. Edited: I see what you are doing. Nevermind. I assume we are copying by t_k, r_k from the gpu somewhere.
jpotoff
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes bad MP moves produce a warning rather than an error. It also tries to reduce the frequency of bad MP moves with Brownian Motion by starting with a smaller initial move amount.