Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing implementation of VK_EXT_hdr_metadata #236

Closed
haasn opened this issue Jun 24, 2021 · 2 comments
Closed

Confusing implementation of VK_EXT_hdr_metadata #236

haasn opened this issue Jun 24, 2021 · 2 comments
Assignees
@qiaojbao
Labels
fixed The issue has been fixed in published build

Comments

@haasn
Copy link

haasn commented Jun 24, 2021

You implement VK_EXT_hdr_metadata in a way where setting HDR metadata forces the internal swapchain color space to HDMI_EOTF_SMPTE_ST2084, completely ignoring the value of pColorConfig->colorSpace.

This means that, effectively, passing HDR metadata puts the display into ST.2084 mode even when the colorSpace chosen for the swapchain is COLOR_SPACE_SRGB_NONLINEAR_KHR, a contradiction. As is, this implementation basically requires users hard-coding undocumented vendor-specific behavior, and leaves important questions unresolved (e.g. what primaries are in use).

The correct way forward, I think, would be to expose support for VK_EXT_swapchain_colorspace, add VK_COLOR_SPACE_HDR10_ST2084_EXT as a valid swapchain color space type, and set the HDMI EOTF depending on this color space.
@qiaojbao
Copy link
Collaborator

Thanks, we will fix it.

JaxLinAMD added a commit that referenced this issue Sep 9, 2021
@JaxLinAMD
2021-9-9 update
87fb643 
New feature and improvement
* Enable extension VK_EXT_load_store_op_none
* Enable extension VK_KHR_zero_initialize_workgroup_memory
* Add exclusion for implicit external synchronization if there is no layout transition
* Update Khronos Headers to 1.2.188
* Valhiem shader optimization

Issue fix
* [XGL issue #126] Switchable graphics layer filters out cards AMDVLK dropped support for
* Heavy flickering observed while performing ALT-TAB in Ghost Recon: Breakpoint Vulkan
* Corruption when turning on DebugOverlayEnable
* RPCS3 Corruption observed on game window
* [AMDVLK issue #236] Confusing implementation of VK_EXT_hdr_metadata
* GPU Profiler: per-draw SPM filenames collide and clobbering each other if the draws use the same shaders
@jinjianrong jinjianrong added the fixed The issue has been fixed in published build label Sep 15, 2021
@jinjianrong
Copy link
Member

@haasn The issue is fixed with v-2021.Q3.6. Please check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiaojbao qiaojbao

Labels
fixed The issue has been fixed in published build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@haasn @jinjianrong @qiaojbao