Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Create a new release #318

Closed
tvoeroes opened this issue Jan 31, 2023 · 7 comments
Closed

Suggestion: Create a new release #318

tvoeroes opened this issue Jan 31, 2023 · 7 comments
Labels
next release To be done as soon as possible quality Code quality improvement e.g. refactoring

Comments

@tvoeroes
Copy link
Contributor

tvoeroes commented Jan 31, 2023

Hello, I was using the v3.0.1 version of the library and was getting some Vulkan validation errors. I tracked the errors back to an issue that was fixed in 1022be6 (22. Jun 2022). In my opinion, such a fix deserves a version bump.

@adam-sawicki-a adam-sawicki-a added next release To be done as soon as possible quality Code quality improvement e.g. refactoring labels Feb 1, 2023
@adam-sawicki-a
Copy link
Contributor

New release is planned, but for now I recommend to always use latest code form the main branch. It is kept in a good state, with no broken builds, unfinished or untested features.

@scribam
Copy link
Contributor

scribam commented Apr 7, 2023

Having a new release will make the changes available for the Vulkan SDK. In the release notes https://vulkan.lunarg.com/doc/sdk/1.3.243.0/windows/release_notes.html, part "SDK Components", you can see the tag 3.0.1 is used for AMD Memory Allocator.

@juan-lunarg
Copy link
Contributor

Note. We are going to use current ToT (0e89587) for the upcoming Vulkan SDK. Based on input from @adam-sawicki-a and @neurotok.

@juan-lunarg
Copy link
Contributor

Note: Vulkan SDK 1.3.250 uses 0e89587 instead of the 3.0.1 tag.

If there is a new release of Vulkan-Memory-Allocator the gpuopen webpage should also be updated. It's currently listing 3.0.0 as the latest release.

https://gpuopen.com/vulkan-memory-allocator/

image

Considering we release

@mjrister
Copy link

mjrister commented May 16, 2024

New release is planned, but for now I recommend to always use latest code form the main branch. It is kept in a good state, with no broken builds, unfinished or untested features.

If the main branch is kept in a good state, why can't this be used to create a new minor release? This is problematic because the official documentation references APIs that are not in the 3.0.1 release (e.g., vmaCopyMemoryToAllocation). Also, for users of vcpkg, I don't believe there is an option to upgrade a port based on a specific git commit and even if there was, it's unclear what commit to use.

@adam-sawicki-a
Copy link
Contributor

What is left to do before calling it a new release is mostly CI build for Linux. Builds on Travis CI stopped working more than a year ago:
https://app.travis-ci.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator
Any help in setting up some free CI builds for Linux is welcome. Would GitHub Actions work? It doesn't need to launch any GPU workload, just test if the code compiles. Preferably on both Clang and GCC.

@adam-sawicki-a
Copy link
Contributor

A new release has been tagged: https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/releases/tag/v3.1.0

I am sorry it took so long. I will try to create new releases more frequently whenever there is a major fix or addition to the library code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release To be done as soon as possible quality Code quality improvement e.g. refactoring
Projects
None yet
Development

No branches or pull requests

5 participants