Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs and fix issue with downloading models (Scotese 2008)? #149

Open
nickywright opened this issue Nov 23, 2023 · 10 comments
Open

update docs and fix issue with downloading models (Scotese 2008)? #149

nickywright opened this issue Nov 23, 2023 · 10 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request low on ice put the issue on ice for now pending

Comments

@nickywright
Copy link
Collaborator

gdownload = gplately.download.DataServer("Scotese2008")
rotation_model, topology_features, static_polygons = gdownload.get_plate_reconstruction_files()

Downloads a zip file and gives me the error:

ConnectionError: A connection to https://static.cambridge.org/content/id/urn:cambridge.org:id:article:S0016756818000110/resource/name/S0016756818000110sup001.zip could not be made. Please check your internet connection and/or ensure the URL is correct. No file from the given URL has been cached to /Users/nickywright/Library/Caches/gplately yet - nothing has been returned.

But these two lines work fine with "Scotese2016"

The rotation files for these two models are exactly the same, but the docs have different ✅ on here for the files associated with the model (e.g. 2008 has topologies? 2016 has static polygons - are these his 'PlatePolygon.gpml?').
Should these be consistent between the two if it's the same model, or are they actually different models?

@nickywright
Copy link
Collaborator Author

The docs still don't mention plate-model-manager...? and plate-model-manager also has different models to gplately.download.DataServer

@michaelchin
Copy link
Contributor

The docs still don't mention plate-model-manager...? and plate-model-manager also has different models to gplately.download.DataServer

The online doc will be updated after next release. The official doc must be compatible with the current official release. Some software have "Dev" version doc. Unfortunately for gplately, we currently do not have "Dev" version doc, although it is open to discussion.

@michaelchin
Copy link
Contributor

Bianca is uploading models to Zenodo. I believe the plan is for us to finalise the list of models after she has finished consolidating the models.

I know little about the Scotese2008 or Scotese2016 model. Currently the Scotese2016 is just an alias of paleomap model in plate-model-manage and the files were grabbed from https://www.earthbyte.org/webdav/ftp/incoming/mchin/plate-models/PALEOMAP/.

I know little about the history of Scotese2008 or Scotese2016 models in DataServer.

@michaelchin michaelchin added documentation Improvements or additions to documentation enhancement New feature or request low pending labels Jun 4, 2024
@michaelchin
Copy link
Contributor

Not sure what to do for now, so add "pending" label. Waiting for customer's feedback.

@michaelchin
Copy link
Contributor

I can add new model in plate-model-manager if I know what to add and where to get the files.

@michaelchin
Copy link
Contributor

We have introduced "documentation versioning" in #187

The latest dev doc is at https://gplates.github.io/gplately/dev-doc/

@michaelchin
Copy link
Contributor

This issue will be resolved when #189 is finalised.

@michaelchin
Copy link
Contributor

Just for the record

I have updated the readme.md with links to various doc versions

https://github.com/GPlates/gplately?tab=readme-ov-file#api-documentation

Screenshot 2024-07-02 at 5 42 04 PM

@michaelchin
Copy link
Contributor

michaelchin commented Jul 4, 2024

The rotation files for these two models are exactly the same, but the docs have different ✅ on here for the files associated with the model (e.g. 2008 has topologies? 2016 has static polygons - are these his 'PlatePolygon.gpml?').

I can confirm that Scotese2008 has no topologies.
Screenshot 2024-07-04 at 1 13 05 PM

@michaelchin michaelchin added the on ice put the issue on ice for now label Jul 5, 2024
@michaelchin
Copy link
Contributor

Scotese2008 will be dropped in the next GPlately release. Customers are advised to use Scotese2016 instead.

We have done everything we could regarding this issue so far. Put this issue "on ice" for two months just in case the customer has more complaints. This issue should be closed if not hear from the customer for 2 months.

Pending close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request low on ice put the issue on ice for now pending
Projects
None yet
Development

No branches or pull requests

2 participants