Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo QA - Homepage #83

Closed
ToniBonittoGSA opened this issue Oct 10, 2017 · 3 comments
Closed

Demo QA - Homepage #83

ToniBonittoGSA opened this issue Oct 10, 2017 · 3 comments
Assignees

Comments

@ToniBonittoGSA
Copy link
Contributor

ToniBonittoGSA commented Oct 10, 2017

Homepage
https://demo.digitalgov.gov/index.html

Keyboard tabbing
ok until I hit articles; no dashed outline around featured images; is on 'read more' button and title

There used to be dashed outline around the Search button at top right, but, I see is missing on live and demo sites

Events
tab order goes thru each event ok, then to View All Events, which is above the events; it should be below.

Has 3 events for this month; live only has 2 -- should Janelle/CC add to live site so ppl can register?

Programs & Services
no dashed outline around featured images; is on 'read more' button and title

If still using this layout come February '18, the Sites block will have to be replaced with something else


Also, we removed Subscribe info & box from above footer last year because of HubSpot's send limit.. return?

@thisisdano
Copy link
Contributor

@ToniBonittoGSA Thanks for this. I think I see the keyboard tabbing (and dotted highlight) issues and the view all events issue on digitalgov.gov right now. I think there is some confusion around having multiple targets per issue link, but I'd like to hold on fixing anything until after the transition. It's maybe counterintuitive, but I'd like (as much as possible) to transition warts and all, as closely to the existing state as possible, and only make improvements once the new site is in place. So, I'll keep this issue open, but wait until later to address these things. OK?

And the Subscribe box stuff is all new to me. Is something we want to reinstate once the site is over on Federalist?

@ToniBonittoGSA
Copy link
Contributor Author

Gotcha, sounds like a plan 👍

@jeremyzilar
Copy link
Contributor

@ToniBonittoGSA I am closing. Feel free to re-open a new issue if there are things here that are outstanding bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants