Adjust positional arguments flagged by flake8-bugbear #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccostino
added
engineering
dependencies
The new release of flake8-bugbear is starting to flag positional argument unpacking that comes after keyword arguments in function calls as a style warning that fails. This is a good thing to catch because it can lead to unexpected side effects with function arguments and/or errors thrown by Python. See the following links for more details: - https://stackoverflow.com/questions/58961715/python-value-unpacking-order-in-method-parameters - python/cpython#82741 This changeset fixes a couple of instances where the positional argument unpacking was happening after keyword arguments were being provided. Signed-off-by: Carlo Costino <carlo.costino@gsa.gov>
ccostino
force-pushed
the
fix-positional-arguments
branch
from
541ee96
to
86fbaee
Compare
stvnrlly
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new release of flake8-bugbear is starting to flag positional argument unpacking that comes after keyword arguments in function calls as a style warning that fails. This is a good thing to catch because it can lead to unexpected side effects with function arguments and/or errors thrown by Python.
See the following links for more details:
This changeset fixes a couple of instances where the positional argument unpacking was happening after keyword arguments were being provided. I've tested these changes both before and after updating the
flake8-bugbeardependency locally, and the site loads fine and the tests all pass.Security Considerations