Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kedro mlflow cli is broken if configuration is declared in pyproject.toml #157

Closed
Galileo-Galilei opened this issue Jan 11, 2021 · 1 comment · Fixed by #166
Closed

kedro mlflow cli is broken if configuration is declared in pyproject.toml #157

Galileo-Galilei opened this issue Jan 11, 2021 · 1 comment · Fixed by #166
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Galileo-Galilei
Copy link
Owner

Description

Kedro enable to declare configuration either in .kedro.yml or in pyproject.toml (in the [tool.kedro] section). We claim to support both, but the CLI commands are not accessible if the project contains only a pyproject.toml file.

Steps to Reproduce

Call kedro mlflow init inside a project with no .kedro.yml file but only a pyproject.toml.

Expected Result

The cli commands should be available (init)

Actual Result

Only the new command is available. This is not considered as a kedro project.

-- Separate them if you have more than one.

Your Environment

  • kedro and kedro-mlflow version used (pip show kedro and pip show kedro-mlflow): kedro==16.6, kedro-mlflow==0.4.1
  • Python version used (python -V): 3.7.9
  • Operating system and version: Windows 7

Does the bug also happen with the last version on develop?

Yes

Solution

The error comes from the is_kedro_project function which does not consider that a folder is the root of a kdro project if it does not contain a .kedro.yml.

@Galileo-Galilei Galileo-Galilei added the bug Something isn't working label Jan 11, 2021
@Galileo-Galilei Galileo-Galilei self-assigned this Jan 11, 2021
@Galileo-Galilei Galileo-Galilei added this to the Release 0.5.0 milestone Jan 11, 2021
@Galileo-Galilei
Copy link
Owner Author

This will wait the migration to kedro>=0.17.0 (cf. #144) in milestone 0.6.0 because kedro has bradnd new utilities to handle this part. This will remove boilerplate code from the plugin and ensure consistency with future kedro changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant