Better error message when gdbserver fails on LD_PRELOAD #1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #1069. I have added a deeper description "what is going on under the hood" below.
When one passes a
env={'LD_PRELOAD': '...'}
togdb.debug
which cannot be preloaded theprocess_created
string in_gdbserver_port
might end up looking like this:And this makes so that pwndbg ends up showing an unintuitive error:
This patch adds a special check whether the
process_created
string starts with'ERROR:'
. If so, it raises an exception, so things are more clear for the user:I assume this is rather an enhancement instead of a super important hotfix, so I am targeting dev branch for now.
If you want, either switch it or tell me to do so (if it cannot be done automatically).