Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix call from gdb.debug to qemu.ld_prefix #1152

Merged
merged 2 commits into from
May 25, 2018

Conversation

f0rki
Copy link
Contributor

@f0rki f0rki commented May 18, 2018

gdb.debug calls qemu.ld_prefix with env as first parameter. The signature of ld_trace is

def ld_prefix(path=None, env=None):

So env is passed as path. This results in path being an enironment dictionary, which is breaking launching qemu --help to get the LD_PREFIX in this line.

@f0rki
Copy link
Contributor Author

f0rki commented May 25, 2018

Is the CI generally broken? From the error message it seems to be some other problem?

@zachriggle zachriggle merged commit fe6619b into Gallopsled:stable May 25, 2018
@f0rki f0rki deleted the fix_gdb_qemu branch July 2, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants