Variable Size Buffer Fill #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently I had left in auditing code for it. :-/ Took that out. |
|
There are some minor nits that I'd like to fix before accepting this PR. Would you mind enabling maintainer changes to your https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/ |
|
The check box appears to be checked for "Allow edits from maintainers". Am I missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Sorry, had already made the changes on a new copy instead of rebase. In any case, i think i got your comments corrected. Snake case, added args, kwargs transparent passing, changed name of variable, added the method to Buffer. Also, tested out that these changes do indeed set the buffer_fill_size as I would expect.