Make sock.connected much more robust by using socket.poll #817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code for
sock.can_recv_raw
andsock.connected_raw
are a bit lacking, and only show what we know about the socket.Specifically,
can_recv_raw()
will returnTrue
if the socket has closedrecv
will immediately throwEOFError
tube.can_recv
connected()
only knows about the internal statewhile sock.connected(): time.sleep(1)
will never returnThis adds a bit of code using
socket.poll
forconnected_raw()
, andrecv(..., MSG_PEEK)
forcan_recv_raw()
.