Fix hexdump regression in 3.3.1 #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@idolf You want to hit the release button again? Feel free to nuke 3.3.1 and re-release, or just bump to 3.3.2. |
|
Sigh. Releasing 3.3.2 now. |
|
Done. |
zachriggle
added a commit
to zachriggle/pwntools
that referenced
this pull request
Jan 10, 2017
Related: Gallopsled#837 Related: Gallopsled#840
zachriggle
added a commit
that referenced
this pull request
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoops. Fixed on regression, added another. Accidentally removed code folding entirely. Not sure if I'm just dumb, or some .pyc weirdness made things appear to work.
This is why we need tests, I just don't want to rewrite hexdump (again!) to make them viable.