Respect TERM_PROGRAM for run_in_new_terminal. Fixes #964. #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also needs to set "arts"
…On Sun, Apr 30, 2017 at 9:02 PM David Tomaschik ***@***.***> wrote:
This respects TERM_PROGRAM for run_in_new_terminal, as documented in the
relevant docstring. :)
Since this affects stable, I based my change against stable (though beta
and dev are affected as well).
Tested locally, though it even seems obviously correct.
------------------------------
You can view, comment on, or merge this pull request online at:
#967
Commit Summary
- Respect TERM_PROGRAM for run_in_terminal. Fixes #964.
File Changes
- *M* pwnlib/util/misc.py
<https://github.com/Gallopsled/pwntools/pull/967/files#diff-0> (2)
Patch Links:
- https://github.com/Gallopsled/pwntools/pull/967.patch
- https://github.com/Gallopsled/pwntools/pull/967.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#967>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAG0GDDUY0-ZFnI23wkYz2FGlvXeRCjsks5r1T0zgaJpZM4NMxaz>
.
|
|
Updated. I contemplated splitting on spaces so one could to TERM_PROGRAM="gnome-terminal -e", but I wasn't sure if that would fit with the intent of the arg. |
|
How does everything else handle TERM_PROGRAM? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This respects TERM_PROGRAM for run_in_new_terminal, as documented in the relevant docstring. :)
Since this affects stable, I based my change against stable (though beta and dev are affected as well).
Tested locally, though it even seems obviously correct.