Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify corefiles are the same via hash before using cached copy #970

Merged
merged 1 commit into from
May 4, 2017

Conversation

zachriggle
Copy link
Member

Fixes #969

@zachriggle zachriggle added the bug label May 3, 2017
@zachriggle zachriggle added this to the 3.5.0 milestone May 3, 2017
@zachriggle zachriggle self-assigned this May 3, 2017
@zachriggle
Copy link
Member Author

I've verified that this works correctly in a Docker instance.

Generating core-files of a running process, even without its state changing, will result in different SHA256 sums, so those will always be re-loaded.

Loading the corefile of a dead (dumped by the kernel) process correctly uses the cached copy.

@zachriggle zachriggle merged commit eaea783 into Gallopsled:stable May 4, 2017
@zachriggle zachriggle deleted the issue_969 branch May 4, 2017 18:04
@zachriggle
Copy link
Member Author

zachriggle commented May 4, 2017

@idolf This affects stable, but there's a new release on Sunday so we can just roll it all together then. I'm not sure if your workflow normally merges stable into beta before promoting beta to stable-staging or however you do it -- but this time, stable → beta merge does need to happen before release.

@TethysSvensson
Copy link
Contributor

@zachriggle ACK

@zachriggle zachriggle restored the issue_969 branch March 21, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants