Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't sign binary artifacts on PRs from forks #1031

Closed
RyanGlScott opened this issue Aug 30, 2022 · 0 comments · Fixed by #1032
Closed

CI: Don't sign binary artifacts on PRs from forks #1031

RyanGlScott opened this issue Aug 30, 2022 · 0 comments · Fixed by #1032
Labels

Comments

@RyanGlScott
Copy link
Contributor

When a pull request is submitted from a fork, it will fail when attempting to sign a binary. See here for an example:

+ sign crux-mir-0.6.0.99-ubuntu-22.04-x86_64.tar.gz
+ set +x
gpg: no valid OpenPGP data found.

This is because the OpenPGP secrets are only provided when running PRs from the main crucible repo, not from forks. To avoid this, we should skip the signing step when running a PR from a fork, much like how we do in Cryptol (see GaloisInc/cryptol#1409) and saw-script (see GaloisInc/saw-script@eedcba1 and GaloisInc/saw-script@ac082b0). This might require some slight reorganization of .github/ci.sh to decouple the signing step from the rest of zip_dist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant