Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More consistent error reporting when things are not finite. #633

Closed
yav opened this issue Jul 5, 2019 · 1 comment
Closed

More consistent error reporting when things are not finite. #633

yav opened this issue Jul 5, 2019 · 1 comment
Labels
feature request Asking for new or improved functionality maybe-fixed Might be resolved, but this needs to be confirmed. typechecker Issues related to type-checking Cryptol code. UX Issues related to the user experience (e.g., improved error messages)

Comments

@yav
Copy link
Member

yav commented Jul 5, 2019

It would appear that we can say that something is not finite in multiple ways:

  • inf is not finite.
  • Expected a finite type, but found inf.

We should normalize this and always use the same language.
yav added a commit that referenced this issue Jul 5, 2019
@yav
Fix test. The error message changed, but is still valid.
ca4968f 
We should really have only one way to say this,
I made a ticket: #633
@yav yav added feature request Asking for new or improved functionality typechecker Issues related to type-checking Cryptol code. labels Jul 5, 2019
@robdockins robdockins added the UX Issues related to the user experience (e.g., improved error messages) label Jan 29, 2021
@brianhuffman brianhuffman added the maybe-fixed Might be resolved, but this needs to be confirmed. label Jan 29, 2021
@robdockins
Copy link
Contributor

I can't reproduce, and I think we fixed this some time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Asking for new or improved functionality maybe-fixed Might be resolved, but this needs to be confirmed. typechecker Issues related to type-checking Cryptol code. UX Issues related to the user experience (e.g., improved error messages)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yav @brianhuffman @robdockins