From 3fa26f9fb9319e287d6a8250ca85427d1abd595d Mon Sep 17 00:00:00 2001 From: Aaron Tomb Date: Thu, 8 Jul 2021 15:12:44 -0700 Subject: [PATCH 1/2] Attempt to fix allowed test failure on Windows --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 140beec4f..aaba18055 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -210,7 +210,7 @@ jobs: continue-on-error: false - suite: rpc target: '' - os: windows + os: windows-latest continue-on-error: true # TODO: get Python client to work on Windows steps: - uses: actions/checkout@v2 From badc155d6138803e1b2757cd3309e172cef37db1 Mon Sep 17 00:00:00 2001 From: Aaron Tomb Date: Thu, 8 Jul 2021 15:58:39 -0700 Subject: [PATCH 2/2] Disable windows RPC tests They seem to hang instead of failing at the moment, so until we get them working it seems like it's better to just leave them out. --- .github/workflows/ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aaba18055..e3330a412 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -197,7 +197,7 @@ jobs: matrix: suite: [test-lib] target: ${{ fromJson(needs.build.outputs.test-lib-json) }} - os: [ubuntu-latest, macos-latest, windows-latest] + os: [ubuntu-latest, macos-latest] # , windows-latest] continue-on-error: [false] include: - suite: rpc @@ -208,10 +208,10 @@ jobs: target: '' os: macos-latest continue-on-error: false - - suite: rpc - target: '' - os: windows-latest - continue-on-error: true # TODO: get Python client to work on Windows + #- suite: rpc + # target: '' + # os: windows-latest + # continue-on-error: true # TODO: get Python client to work on Windows steps: - uses: actions/checkout@v2 with: