Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regression test for issue #835. #1410

Closed
wants to merge 2 commits into from
Closed

Remove regression test for issue #835. #1410

wants to merge 2 commits into from

Conversation

taimoorzaeem
Copy link
Contributor

Fixes issue #1329.

@RyanGlScott
Copy link
Contributor

Thanks for the pull request!

Rather than deleting the test case, I think we could just adapt it so that it actually exercises the part of the pretty printer that is responsible for parenthesizing compound expressions. Something like this would suffice:

Cryptol> :m Float
Loading module Cryptol
Loading module Float
Float> :t number`{1, Float _ _}
number`{1, Float _ _} :
  {n, m} (ValidFloat n m, Literal 1 (Float n m)) => Float n m

The fact that it is printed like Literal 1 (Float n m) is a sign that the fix for #835 is working.

@taimoorzaeem taimoorzaeem deleted the issue1329 branch August 25, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants