Make fromTo and friends return VWord when appropriate
#1436
+56
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous, `fromTo` and related functions would always return a `VSeq`. If the type happened to be a `Bit`, this would violate the internal invariant that sequences of `Bit`s are always represented with `VWord`s, leading to the panics observed in #1435. This patch fixes the issue by using the `mkSeq` smart constructor, which chooses between `VWord` and `VSeq` depending on the sequence type. Fixes #1435.
yav
approved these changes
Sep 17, 2022
I've opened #1437 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous,
fromToand related functions would always return aVSeq. If the type happened to be aBit, this would violate the internal invariant that sequences ofBits are always represented withVWords, leading to the panics observed in #1435. This patch fixes the issue by using themkSeqsmart constructor, which chooses betweenVWordandVSeqdepending on the sequence type.Fixes #1435.