Skip to content
This repository has been archived by the owner on Aug 15, 2023. It is now read-only.

fix: eslint issues #110

Merged
merged 4 commits into from
Jul 8, 2022
Merged

fix: eslint issues #110

merged 4 commits into from
Jul 8, 2022

Conversation

dolcalmi
Copy link
Collaborator

@dolcalmi dolcalmi commented Jul 7, 2022 •
edited
Loading

  • Fix/update tracing service after dependencies updates 151baa0
  • Add proper eslint config to dealer workspace + include prettier dependency 97f7600
  • Fix eslint issues (only changes from running yarn dealer eslint-fix) eddf9f8
  • Update packages + fix related issues b74ff76
    • Remove unnecessary config files from root folder
    • Remove dateformat package, was throwing an exception in jest build but it was only needed in mocks. Replaced by getTime
    • The most risky update is graphql, if you can please check servers locally
    • @galoymoney/client could not be upgraded to the last version. I need to verify with samer and issue with peer dependencies and yarn

@dolcalmi dolcalmi marked this pull request as draft July 7, 2022 01:03
@dolcalmi dolcalmi marked this pull request as ready for review July 7, 2022 05:14
sebastienverreault
sebastienverreault approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@sebastienverreault sebastienverreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dolcalmi dolcalmi merged commit b57212b into main Jul 8, 2022
galoybot pushed a commit that referenced this pull request Aug 22, 2022
@krtk6160
Merge pull request #110 from GaloyMoney/dependabot/npm_and_yarn/postc…
1373a2e 
…ss-normalize-9.0.0

Bump postcss-normalize from 8.0.1 to 9.0.0
galoybot pushed a commit that referenced this pull request Aug 22, 2022
@krtk6160
Revert "Merge pull request #110 from GaloyMoney/dependabot/npm_and_ya…
80e48fc 
…rn/postcss-normalize-9.0.0"

This reverts commit 1373a2e, reversing
changes made to 775b830.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sebastienverreault sebastienverreault sebastienverreault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dolcalmi @sebastienverreault