This repository has been archived by the owner on Aug 15, 2023. It is now read-only.
Feat: keep funding reserve on exchange #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolcalmi
reviewed
Jul 14, 2022
| hedgingBounds.MINIMUM_FUNDING_BALANCE_BTC, | ||
| ) | ||
| } else { | ||
| this.logger.error( |
There was a problem hiding this comment.
not sure to understand this.. if this.getFundingAccountBalance() fail then we continue trying to withdraw?
also, I prefer the other style that you use for ok returns, something like line 584
if (!fundingAccountBalanceResult.ok) {
this.logger.error(
{ fundingAccountBalanceResult },
"getFundingAccountBalance() error: {fundingAccountBalanceResult}",
)
return { ... }
}
newTransferSizeInBtc = Math.max(
0,
fundingAccountBalanceResult.value.btcFreeBalance -
hedgingBounds.MINIMUM_FUNDING_BALANCE_BTC,
)
There was a problem hiding this comment.
Yeah if it fails too bad or should it be an alert to get attention?
dolcalmi
approved these changes
Jul 14, 2022
Comment on lines
+540
to
+541
| fundingAccountBalanceResult.value.btcFreeBalance - | ||
| hedgingBounds.MINIMUM_FUNDING_BALANCE_BTC, |
There was a problem hiding this comment.
any reason to just not do a comparison? fundingAccountBalanceResult.value.btcFreeBalance > hedgingBounds.MINIMUM_FUNDING_BALANCE_BTC
| this.logger.error( | ||
| { withdrawalResponse }, | ||
| "rebalancing withdrawal was NOT successful", | ||
| this.logger.debug( |
There was a problem hiding this comment.
same issue here with the else block.. code is cleaner using an early return
galoybot
pushed a commit
that referenced
this pull request
Aug 22, 2022
…/bootstrap-5.1.6 Bump @types/bootstrap from 4.6.1 to 5.1.6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.